[evolution-data-server] Bug 705206 - Stale "Retrieving message xxx" in preview panel



commit fab4ebc81305cddcb92776d23c2498d41e0ff0c6
Author: Matthew Barnes <mbarnes redhat com>
Date:   Fri Aug 2 16:31:20 2013 +0200

    Bug 705206 - Stale "Retrieving message xxx" in preview panel
    
    A client application cancelling an operation should not terminate the
    parser thread.  The parser thread completes the operation even if the
    client is no longer interested in the result.  The parser thread loop
    must only be broken out of on an I/O error, parsing error, the server
    hanging up, or application shutdown.

 camel/camel-imapx-command.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)
---
diff --git a/camel/camel-imapx-command.c b/camel/camel-imapx-command.c
index efe689a..d297b56 100644
--- a/camel/camel-imapx-command.c
+++ b/camel/camel-imapx-command.c
@@ -581,9 +581,6 @@ gboolean
 camel_imapx_command_set_error_if_failed (CamelIMAPXCommand *ic,
                                          GError **error)
 {
-       CamelIMAPXJob *job;
-       GCancellable *cancellable = NULL;
-
        g_return_val_if_fail (CAMEL_IS_IMAPX_COMMAND (ic), FALSE);
 
        if (ic->status != NULL && ic->status->result != IMAPX_OK) {
@@ -610,11 +607,7 @@ camel_imapx_command_set_error_if_failed (CamelIMAPXCommand *ic,
                return TRUE;
        }
 
-       job = camel_imapx_command_get_job (ic);
-       if (job != NULL)
-               cancellable = camel_imapx_job_get_cancellable (job);
-
-       return g_cancellable_set_error_if_cancelled (cancellable, error);
+       return FALSE;
 }
 
 CamelIMAPXCommandQueue *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]