[gnome-initial-setup] keyboard/input-chooser: Avoid dereference of possible NULL pointer



commit 6da09ba1ac061213958bc790f633f1a4fa8e7ca0
Author: Michael Wood <michael g wood intel com>
Date:   Thu Aug 1 12:06:50 2013 +0100

    keyboard/input-chooser: Avoid dereference of possible NULL pointer
    
    child_info can be NULL if the before_info is valid stopping the
    update_separator_filter function from returning.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705279

 .../pages/keyboard/cc-input-chooser.c              |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gnome-initial-setup/pages/keyboard/cc-input-chooser.c 
b/gnome-initial-setup/pages/keyboard/cc-input-chooser.c
index f31c0a1..077be91 100644
--- a/gnome-initial-setup/pages/keyboard/cc-input-chooser.c
+++ b/gnome-initial-setup/pages/keyboard/cc-input-chooser.c
@@ -565,7 +565,7 @@ update_separator_filter (GtkWidget **separator,
   if (before)
     before_info = g_object_get_data (G_OBJECT (before), "locale-info");
 
-  if (!child_info && !before_info)
+  if (!child_info || !before_info)
     return;
 
   if (child_info == before_info)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]