[gnome-settings-daemon] power: Remove pre-dim brightness hack

[Bastien Nocera <hadess src gnome org>]

commit f06c7fca2fef255b39690c5da8c5aa0fcb2f0079
Author: Bastien Nocera <hadess hadess net>
Date:   Sat Apr 20 15:21:44 2013 +0200

    power: Remove pre-dim brightness hack
    
    We were trying to work-around the fact that switching to the
    VT on some laptops re-enabled the backlight.
    
    The backlight level is however incorrect when DPMS mode off, and
    checking the level of the backlight, when DPMS is still on, caused
    races.
    
    Linux kernel 3.10 will remove the need for VT switching which will
    fix this bug properly:
    http://blog.ffwll.ch/2013/04/neat-drmi915-stuff-for-310.html
    
    https://bugzilla.gnome.org/show_bug.cgi?id=696379

 plugins/power/gsd-power-manager.c |   22 ----------------------
 plugins/power/test.py             |    3 ---
 2 files changed, 0 insertions(+), 25 deletions(-)
---
diff --git a/plugins/power/gsd-power-manager.c b/plugins/power/gsd-power-manager.c
index e141be5..ebd60a6 100644
--- a/plugins/power/gsd-power-manager.c
+++ b/plugins/power/gsd-power-manager.c
@@ -189,7 +189,6 @@ struct GsdPowerManagerPrivate
         /* Brightness */
         gboolean                 backlight_available;
         gint                     pre_dim_brightness; /* level, not percentage */
-        gint                     pre_dpms_brightness;
 
         /* Keyboard */
         GDBusProxy              *upower_kdb_proxy;
@@ -1993,11 +1992,6 @@ backlight_enable (GsdPowerManager *manager)
                 g_error_free (error);
         }
 
-        if (manager->priv->backlight_available &&
-            manager->priv->pre_dpms_brightness != -1) {
-                backlight_set_abs (manager->priv->rr_screen, manager->priv->pre_dpms_brightness, &error);
-                manager->priv->pre_dpms_brightness = -1;
-        }
         g_debug ("TESTSUITE: Unblanked screen");
 }
 
@@ -2007,21 +2001,6 @@ backlight_disable (GsdPowerManager *manager)
         gboolean ret;
         GError *error = NULL;
 
-        /* Save the backlight, if DPMS isn't on yet, so we can capture it */
-#ifndef GSD_MOCK
-        GnomeRRDpmsMode mode;
-
-        if (manager->priv->backlight_available &&
-            gnome_rr_screen_get_dpms_mode (manager->priv->rr_screen, &mode, NULL) &&
-            mode == GNOME_RR_DPMS_ON) {
-                manager->priv->pre_dpms_brightness = backlight_get_abs (manager->priv->rr_screen, NULL);
-        }
-#else
-        manager->priv->pre_dpms_brightness = backlight_get_abs (manager->priv->rr_screen, NULL);
-#endif /* GSD_MOCK */
-        if (manager->priv->pre_dpms_brightness != -1)
-                backlight_set_abs (manager->priv->rr_screen, backlight_get_min (manager->priv->rr_screen), 
NULL);
-
         ret = gnome_rr_screen_set_dpms_mode (manager->priv->rr_screen,
                                              GNOME_RR_DPMS_OFF,
                                              &error);
@@ -3652,7 +3631,6 @@ gsd_power_manager_init (GsdPowerManager *manager)
         manager->priv = GSD_POWER_MANAGER_GET_PRIVATE (manager);
         manager->priv->inhibit_lid_switch_fd = -1;
         manager->priv->inhibit_suspend_fd = -1;
-        manager->priv->pre_dpms_brightness = -1;
         manager->priv->screensaver_cancellable = g_cancellable_new ();
         manager->priv->bus_cancellable = g_cancellable_new ();
 }
diff --git a/plugins/power/test.py b/plugins/power/test.py
index 3159b23..7f54944 100755
--- a/plugins/power/test.py
+++ b/plugins/power/test.py
@@ -348,8 +348,6 @@ class PowerPluginTest(gsdtestcase.GSDTestCase):
 
         # blank is supposed to happen straight away
         self.check_blank(2)
-        # check that the brightness is at the minimum
-        self.assertTrue(self.get_brightness() == 0, 'incorrect blank brightness (%d != 0)' % 
(self.get_brightness()))
 
         # wiggle the mouse now and check for unblank; this is expected to pop up
         # the locked screen saver
@@ -363,7 +361,6 @@ class PowerPluginTest(gsdtestcase.GSDTestCase):
 
         # and check for blank after the blank timeout
         self.check_blank(10)
-        self.assertTrue(self.get_brightness() == 0, 'incorrect blank brightness (%d != 0)' % 
(self.get_brightness()))
 
         # Drop inhibitor
         self.obj_session_mgr.Uninhibit(dbus.UInt32(inhibit_id))