[gnumeric] fix criticals #698624



commit 659c93f45ceff385601784738f10d9f8711dc409
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date:   Mon Apr 22 16:56:53 2013 -0600

    fix criticals #698624
    
    2013-04-22  Andreas J. Guelzow <aguelzow pyrshep ca>
    
        * src/sheet.c (sheet_range_set_expr_cb): don't try to empty empty
        cells.
        (sheet_range_set_text): ditto

 ChangeLog   | 6 ++++++
 src/sheet.c | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 31bb54e..5823372 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2013-04-22  Andreas J. Guelzow <aguelzow pyrshep ca>
 
+       * src/sheet.c (sheet_range_set_expr_cb): don't try to empty empty
+       cells.
+       (sheet_range_set_text): ditto
+
+2013-04-22  Andreas J. Guelzow <aguelzow pyrshep ca>
+
        * src/sheet-control-gui.c (scg_comment_display): use spacing rather
        than padding.
 
diff --git a/src/sheet.c b/src/sheet.c
index 0fcf8dc..8e3dc8b 100644
--- a/src/sheet.c
+++ b/src/sheet.c
@@ -2622,7 +2622,7 @@ sheet_range_set_expr_cb (GnmSheetRange const *sr, GnmExprTop const *texpr)
        for (ptr = merged ; ptr != NULL ; ptr = ptr->next) {
                GnmRange const *tmp = ptr->data;
                sheet_foreach_cell_in_range
-                       (sr->sheet, CELL_ITER_ALL,
+                       (sr->sheet, CELL_ITER_IGNORE_BLANK,
                         tmp->start.col, tmp->start.row,
                         tmp->end.col, tmp->end.row,
                         (CellIterFunc)&cb_clear_non_corner,
@@ -2696,7 +2696,7 @@ sheet_range_set_text (GnmParsePos const *pos, GnmRange const *r, char const *str
        merged = gnm_sheet_merge_get_overlap (sheet, r);
        for (ptr = merged ; ptr != NULL ; ptr = ptr->next) {
                GnmRange const *tmp = ptr->data;
-               sheet_foreach_cell_in_range (sheet, CELL_ITER_ALL,
+               sheet_foreach_cell_in_range (sheet, CELL_ITER_IGNORE_BLANK,
                        tmp->start.col, tmp->start.row,
                        tmp->end.col, tmp->end.row,
                        (CellIterFunc)&cb_clear_non_corner, (gpointer)tmp);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]