[goffice] Don't unref a disposed widget. [#698150]
- From: Jean Bréfort <jbrefort src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [goffice] Don't unref a disposed widget. [#698150]
- Date: Tue, 16 Apr 2013 17:19:07 +0000 (UTC)
commit 3e0db576037b2044e5546c5a19fb89c415a5ccd7
Author: Jean Brefort <jean brefort normalesup org>
Date: Tue Apr 16 19:26:20 2013 +0200
Don't unref a disposed widget. [#698150]
ChangeLog | 6 ++++++
NEWS | 1 +
goffice/utils/go-editor.c | 2 +-
3 files changed, 8 insertions(+), 1 deletion(-)
---
diff --git a/ChangeLog b/ChangeLog
index 1cd0626..344c566 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
2013-04-16 Jean Brefort <jean brefort normalesup org>
+ * goffice/utils/go-editor.c (go_editor_add_page): add a reference to the
+ widget when not using a scrolled window. Avoids unrefing a disposed object.
+ [#698150]
+
+2013-04-16 Jean Brefort <jean brefort normalesup org>
+
* goffice/canvas/goc-item.c (goc_item_set_transform): fix test. [#698101]
* goffice/utils/go-editor.c (go_editor_new): initialize
GOEditor::use_scrolled. [#698102]
diff --git a/NEWS b/NEWS
index 370f404..965e0af 100644
--- a/NEWS
+++ b/NEWS
@@ -13,6 +13,7 @@ Jean:
series. [#698057]
* Fixed test in goc_item_set_transform(). [#698101]
* Iinitialize GOEditor::use_scrolled. [#698102]
+ * Don't unref a disposed widget. [#698150]
Morten:
* Fix problems with cspline boxed type. [#695550]
diff --git a/goffice/utils/go-editor.c b/goffice/utils/go-editor.c
index 0d24770..76b9584 100644
--- a/goffice/utils/go-editor.c
+++ b/goffice/utils/go-editor.c
@@ -136,7 +136,7 @@ go_editor_add_page (GOEditor *editor, gpointer widget, char const *label)
gtk_scrolled_window_add_with_viewport (GTK_SCROLLED_WINDOW (page->scrolled),
widget);
} else
- page->scrolled = widget;
+ page->scrolled = g_object_ref (widget);
page->label = label;
editor->pages = g_slist_prepend (editor->pages, page);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]