[gnumeric] GUI: Fix undo dirty tracking.



commit f524760bdb189df4f29e58efa4881a431f00275f
Author: Morten Welinder <terra gnome org>
Date:   Sat Apr 13 11:30:03 2013 -0400

    GUI: Fix undo dirty tracking.

 ChangeLog       | 6 ++++++
 NEWS            | 1 +
 src/clipboard.c | 3 ++-
 src/sheet.c     | 1 -
 4 files changed, 9 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 2b3c395..5764dd5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-04-13  Morten Welinder  <terra gnome org>
+
+       * src/sheet.c (sheet_range_calc_spans): Don't mark the sheet
+       dirty.  Callers already appear to handle this when needed
+       and not when not wanted.  Fixes #697927.
+
 2013-04-12  Morten Welinder  <terra gnome org>
 
        * src/mathfunc.c (gnm_owent): Fix a==1 special case.  Part of
diff --git a/NEWS b/NEWS
index f4bbc13..2cbb5a6 100644
--- a/NEWS
+++ b/NEWS
@@ -37,6 +37,7 @@ Morten:
        * New function NT_OMEGA.
        * Fix minor R.PBINOM problems.
        * Improve FACT and GAMMA accuracy.
+       * Fix dirty/undo tracking issue.  [#697927]
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.1
diff --git a/src/clipboard.c b/src/clipboard.c
index 013e2bd..a29f113 100644
--- a/src/clipboard.c
+++ b/src/clipboard.c
@@ -741,7 +741,8 @@ cb_clipboard_copy_range_undo (GnmCellRegion *cr, GnmSheetRange *sr,
  * @sheet: #Sheet
  * @r: #GnmRange
  *
- * Returns: (transfer full):
+ * Returns: (transfer full): A #GOUndo object that will restore the contents
+ * of the given range.
  **/
 GOUndo *
 clipboard_copy_range_undo (Sheet *sheet, GnmRange const *r)
diff --git a/src/sheet.c b/src/sheet.c
index 231a3f4..0fcf8dc 100644
--- a/src/sheet.c
+++ b/src/sheet.c
@@ -1449,7 +1449,6 @@ cb_clear_rendered_values (GnmCellIter const *iter, G_GNUC_UNUSED gpointer user)
 void
 sheet_range_calc_spans (Sheet *sheet, GnmRange const *r, GnmSpanCalcFlags flags)
 {
-       sheet_mark_dirty (sheet);
        if (flags & GNM_SPANCALC_RE_RENDER)
                sheet_foreach_cell_in_range (sheet, CELL_ITER_IGNORE_NONEXISTENT,
                        r->start.col, r->start.row, r->end.col, r->end.row,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]