[rhythmbox] sync: ignore duration when identifying tracks to sync
- From: Jonathan Matthew <jmatthew src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [rhythmbox] sync: ignore duration when identifying tracks to sync
- Date: Sat, 6 Apr 2013 23:20:56 +0000 (UTC)
commit 3aedaa114a2f1bcd39d5b54058806faa4f68da68
Author: Jonathan Matthew <jonathan d14n org>
Date: Sun Apr 7 09:19:11 2013 +1000
sync: ignore duration when identifying tracks to sync
It's not particularly reliable, especially when dealing with transcoded
files, and given that all the other fields have to match, I can only
see this being a problem if there are truncated files on the target
device.
sources/sync/rb-sync-state.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
---
diff --git a/sources/sync/rb-sync-state.c b/sources/sync/rb-sync-state.c
index fc9ff23..6f48035 100644
--- a/sources/sync/rb-sync-state.c
+++ b/sources/sync/rb-sync-state.c
@@ -108,17 +108,14 @@ rb_sync_state_make_track_uuid (RhythmDBEntry *entry)
/*
* possible improvements here:
* - use musicbrainz track ID if known (maybe not a great idea?)
- * - fuzz the duration a bit (round to nearest 5 seconds?) to catch slightly
- * different encodings of the same track
* - maybe don't include genre, since there's no canonical genre for anything
*/
- g_string_printf (str, "%s%s%s%s%lu%lu%lu",
+ g_string_printf (str, "%s%s%s%s%lu%lu",
rhythmdb_entry_get_string (entry, RHYTHMDB_PROP_TITLE),
rhythmdb_entry_get_string (entry, RHYTHMDB_PROP_ARTIST),
rhythmdb_entry_get_string (entry, RHYTHMDB_PROP_GENRE),
rhythmdb_entry_get_string (entry, RHYTHMDB_PROP_ALBUM),
- rhythmdb_entry_get_ulong (entry, RHYTHMDB_PROP_DURATION),
rhythmdb_entry_get_ulong (entry, RHYTHMDB_PROP_TRACK_NUMBER),
rhythmdb_entry_get_ulong (entry, RHYTHMDB_PROP_DISC_NUMBER));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]