[glade/composite-templates-new: 2/6] Test Cases: Now GtkComboBox finalizes properly.
- From: Tristan Van Berkom <tvb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glade/composite-templates-new: 2/6] Test Cases: Now GtkComboBox finalizes properly.
- Date: Fri, 5 Apr 2013 12:31:01 +0000 (UTC)
commit 563e3a346cf4c97e0ced54babac64ee1059fe0b9
Author: Tristan Van Berkom <tristan van berkom gmail com>
Date: Fri Apr 5 19:55:21 2013 +0900
Test Cases: Now GtkComboBox finalizes properly.
The bug had to do with a call to glade_widget_rebuild()
tests/add-child.c | 8 +++-----
tests/create-widgets.c | 2 --
2 files changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/tests/add-child.c b/tests/add-child.c
index 32f8ab4..b7b02c2 100644
--- a/tests/add-child.c
+++ b/tests/add-child.c
@@ -184,9 +184,8 @@ add_child_widgets (GType parent_type)
add_test (parent_type, GTK_TYPE_LINK_BUTTON, assert_widget_parented);
add_test (parent_type, GTK_TYPE_MENU_BUTTON, assert_widget_parented);
- /* FIXME: Combo box types dont finalize properly for some reason */
- /* add_test (parent_type, GTK_TYPE_COMBO_BOX, assert_widget_parented); */
- /* add_test (parent_type, GTK_TYPE_COMBO_BOX_TEXT, assert_widget_parented); */
+ add_test (parent_type, GTK_TYPE_COMBO_BOX, assert_widget_parented);
+ add_test (parent_type, GTK_TYPE_COMBO_BOX_TEXT, assert_widget_parented);
add_test (parent_type, GTK_TYPE_SCALE_BUTTON, assert_widget_parented);
add_test (parent_type, GTK_TYPE_VOLUME_BUTTON, assert_widget_parented);
add_test (parent_type, GTK_TYPE_FONT_BUTTON, assert_widget_parented);
@@ -296,8 +295,7 @@ main (int argc,
add_test (GTK_TYPE_TREE_VIEW, GTK_TYPE_TREE_VIEW_COLUMN, assert_column_parented);
add_child_cells (GTK_TYPE_TREE_VIEW_COLUMN);
add_child_cells (GTK_TYPE_ICON_VIEW);
- /* FIXME: Combo box types dont finalize properly for some reason */
- /* add_child_cells (GTK_TYPE_COMBO_BOX); */
+ add_child_cells (GTK_TYPE_COMBO_BOX);
/* TextTag */
add_test (GTK_TYPE_TEXT_TAG_TABLE, GTK_TYPE_TEXT_TAG, NULL);
diff --git a/tests/create-widgets.c b/tests/create-widgets.c
index 80c53f3..c1e9b6d 100644
--- a/tests/create-widgets.c
+++ b/tests/create-widgets.c
@@ -101,8 +101,6 @@ main (int argc,
adaptor_type != GTK_TYPE_STATUS_ICON &&
/* FIXME: Icon factory adds itself to the default but never removes itself */
adaptor_type != GTK_TYPE_ICON_FACTORY &&
- /* FIXME: Combo box types dont finalize properly for some reason */
- !g_type_is_a (adaptor_type, GTK_TYPE_COMBO_BOX) &&
/* FIXME: FileChooserButton leaks a GTask which will crash in the following test */
adaptor_type != GTK_TYPE_FILE_CHOOSER_BUTTON &&
/* FIXME: App choosers leak some async operations after finalization, causing subsequent tests to
fail */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]