[gimp] app: plug string leak in gimp_image_format_display_uri()



commit 7597b83bd8cb10c57986692098347dd285862c3e
Author: Michael Natterer <mitch gimp org>
Date:   Fri Sep 21 10:34:17 2012 +0200

    app: plug string leak in gimp_image_format_display_uri()

 app/core/gimpimage.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/app/core/gimpimage.c b/app/core/gimpimage.c
index be079a9..73cf815 100644
--- a/app/core/gimpimage.c
+++ b/app/core/gimpimage.c
@@ -1817,6 +1817,7 @@ gimp_image_format_display_uri (GimpImage *image,
   gboolean     is_exported;
   gchar       *display_uri   = NULL;
   gchar       *format_string;
+  gchar       *tmp;
 
   g_return_val_if_fail (GIMP_IS_IMAGE (image), NULL);
 
@@ -1875,19 +1876,23 @@ gimp_image_format_display_uri (GimpImage *image,
     }
   else if (basename)
     {
-      gchar *tmp = file_utils_uri_display_basename (display_uri);
+      tmp = file_utils_uri_display_basename (display_uri);
       g_free (display_uri);
       display_uri = tmp;
     }
   else
     {
-      gchar *tmp = file_utils_uri_display_name (display_uri);
+      tmp = file_utils_uri_display_name (display_uri);
       g_free (display_uri);
       display_uri = tmp;
     }
 
   format_string = g_strconcat (uri_format, export_status, NULL);
-  display_uri = g_strdup_printf (format_string, display_uri);
+
+  tmp = g_strdup_printf (format_string, display_uri);
+  g_free (display_uri);
+  display_uri = tmp;
+
   g_free (format_string);
 
   return display_uri;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]