[dia] [cleanup] remove superfluous #include "message.h"



commit 8ef61c0f489b88651c57e4614ba3500757795811
Author: Hans Breuer <hans breuer org>
Date:   Sat Sep 15 10:50:49 2012 +0200

    [cleanup] remove superfluous #include "message.h"
    
    Programmer's errors, e.g. the wrong fill mode for DiaRenderer::set_fillstyle(),
    should not be signaled by message_error. Also not to be translated.

 plug-ins/drs/dia-render-script-import.c |    1 -
 plug-ins/dxf/dxf-export.c               |    1 -
 plug-ins/dxf/dxf-import.c               |    1 -
 plug-ins/libart/dialibart.c             |    1 -
 plug-ins/libart/dialibartrenderer.c     |    3 ++-
 plug-ins/metapost/render_metapost.c     |    3 ++-
 plug-ins/pgf/render_pgf.c               |    3 ++-
 plug-ins/pixbuf/pixbuf.c                |    1 -
 plug-ins/postscript/diapsrenderer.c     |    4 ++--
 plug-ins/postscript/render_eps.c        |    1 -
 plug-ins/python/python.c                |    1 -
 plug-ins/shape/shape-export.c           |    1 -
 plug-ins/svg/render_svg.c               |    1 -
 plug-ins/vdx/vdx-xml.c                  |    3 +--
 14 files changed, 9 insertions(+), 16 deletions(-)
---
diff --git a/plug-ins/drs/dia-render-script-import.c b/plug-ins/drs/dia-render-script-import.c
index 3c21160..524be9c 100644
--- a/plug-ins/drs/dia-render-script-import.c
+++ b/plug-ins/drs/dia-render-script-import.c
@@ -27,7 +27,6 @@
 #include "color.h"
 #include "diagramdata.h"
 #include "group.h"
-#include "message.h"
 #include "intl.h"
 
 #include <libxml/tree.h>
diff --git a/plug-ins/dxf/dxf-export.c b/plug-ins/dxf/dxf-export.c
index 324a1d7..a858c8e 100644
--- a/plug-ins/dxf/dxf-export.c
+++ b/plug-ins/dxf/dxf-export.c
@@ -34,7 +34,6 @@
 #include "autocad_pal.h"
 
 #include "intl.h"
-#include "message.h"
 #include "geometry.h"
 #include "diarenderer.h"
 #include "filter.h"
diff --git a/plug-ins/dxf/dxf-import.c b/plug-ins/dxf/dxf-import.c
index 84de5b2..490716e 100644
--- a/plug-ins/dxf/dxf-import.c
+++ b/plug-ins/dxf/dxf-import.c
@@ -33,7 +33,6 @@
 #include <glib/gstdio.h>
 
 #include "intl.h"
-#include "message.h"
 #include "geometry.h"
 #include "diarenderer.h"
 #include "filter.h"
diff --git a/plug-ins/libart/dialibart.c b/plug-ins/libart/dialibart.c
index 51ab980..4eafa34 100644
--- a/plug-ins/libart/dialibart.c
+++ b/plug-ins/libart/dialibart.c
@@ -23,7 +23,6 @@
 #include <stdio.h>
 
 #include "intl.h"
-#include "message.h"
 #include "filter.h"
 #include "plug-ins.h"
 
diff --git a/plug-ins/libart/dialibartrenderer.c b/plug-ins/libart/dialibartrenderer.c
index 2de0d63..55ecb89 100644
--- a/plug-ins/libart/dialibartrenderer.c
+++ b/plug-ins/libart/dialibartrenderer.c
@@ -301,7 +301,8 @@ set_fillstyle(DiaRenderer *self, FillStyle mode)
   case FILLSTYLE_SOLID:
     break;
   default:
-    message_error(_("gdk_renderer: Unsupported fill mode specified!\n"));
+    g_warning ("%s: Unsupported fill mode specified!",
+	       G_OBJECT_CLASS_NAME (G_OBJECT_GET_CLASS (self)));
   }
 }
 
diff --git a/plug-ins/metapost/render_metapost.c b/plug-ins/metapost/render_metapost.c
index 4e39081..fd61a3c 100644
--- a/plug-ins/metapost/render_metapost.c
+++ b/plug-ins/metapost/render_metapost.c
@@ -499,7 +499,8 @@ set_fillstyle(DiaRenderer *self, FillStyle mode)
     case FILLSTYLE_SOLID:
 	break;
     default:
-	message_error("metapost_renderer: Unsupported fill mode specified!\n");
+	g_warning ("%s: Unsupported fill mode specified!",
+		   G_OBJECT_CLASS_NAME (G_OBJECT_GET_CLASS (self)));
     }
 }
 
diff --git a/plug-ins/pgf/render_pgf.c b/plug-ins/pgf/render_pgf.c
index 0180e2f..545b0a5 100644
--- a/plug-ins/pgf/render_pgf.c
+++ b/plug-ins/pgf/render_pgf.c
@@ -462,7 +462,8 @@ set_fillstyle(DiaRenderer *self, FillStyle mode)
     case FILLSTYLE_SOLID:
 	break;
     default:
-	message_error("pgf_renderer: Unsupported fill mode specified!\n");
+	g_warning ("%s: Unsupported fill mode specified!",
+		   G_OBJECT_CLASS_NAME (G_OBJECT_GET_CLASS (self)));
     }
 }
 
diff --git a/plug-ins/pixbuf/pixbuf.c b/plug-ins/pixbuf/pixbuf.c
index a530252..b810388 100644
--- a/plug-ins/pixbuf/pixbuf.c
+++ b/plug-ins/pixbuf/pixbuf.c
@@ -26,7 +26,6 @@
 #include <gdk-pixbuf/gdk-pixbuf.h>
 
 #include "intl.h"
-#include "message.h"
 #include "geometry.h"
 #include "diagdkrenderer.h"
 #include "filter.h"
diff --git a/plug-ins/postscript/diapsrenderer.c b/plug-ins/postscript/diapsrenderer.c
index f433491..9fe7876 100644
--- a/plug-ins/postscript/diapsrenderer.c
+++ b/plug-ins/postscript/diapsrenderer.c
@@ -273,8 +273,8 @@ set_fillstyle(DiaRenderer *self, FillStyle mode)
   case FILLSTYLE_SOLID:
     break;
   default:
-    message_error("%s : Unsupported fill mode specified!\n",
-                  G_OBJECT_CLASS_NAME (G_OBJECT_GET_CLASS (renderer)));
+    g_warning ("%s: Unsupported fill mode specified!",
+	       G_OBJECT_CLASS_NAME (G_OBJECT_GET_CLASS (self)));
   }
 }
 
diff --git a/plug-ins/postscript/render_eps.c b/plug-ins/postscript/render_eps.c
index e227d97..a4dd100 100644
--- a/plug-ins/postscript/render_eps.c
+++ b/plug-ins/postscript/render_eps.c
@@ -59,7 +59,6 @@
 
 #include "intl.h"
 #include "render_eps.h"
-#include "message.h"
 #include "diagramdata.h"
 #include "font.h"
 #include "diapsrenderer.h"
diff --git a/plug-ins/python/python.c b/plug-ins/python/python.c
index f27ab17..54b3e02 100644
--- a/plug-ins/python/python.c
+++ b/plug-ins/python/python.c
@@ -28,7 +28,6 @@
 #include "intl.h"
 #include "plug-ins.h"
 #include "dia_dirs.h"
-#include "message.h"
 
 #include "pydia-error.h"
 
diff --git a/plug-ins/shape/shape-export.c b/plug-ins/shape/shape-export.c
index bfa98c4..96d326f 100644
--- a/plug-ins/shape/shape-export.c
+++ b/plug-ins/shape/shape-export.c
@@ -59,7 +59,6 @@
 #include "diasvgrenderer.h"
 #include "filter.h"
 #include "intl.h"
-#include "message.h"
 #include "diagramdata.h"
 #include "object.h"
 
diff --git a/plug-ins/svg/render_svg.c b/plug-ins/svg/render_svg.c
index 54f2322..029a0ad 100644
--- a/plug-ins/svg/render_svg.c
+++ b/plug-ins/svg/render_svg.c
@@ -40,7 +40,6 @@
 #include "diasvgrenderer.h"
 #include "filter.h"
 #include "intl.h"
-#include "message.h"
 #include "diagramdata.h"
 #include "dia_xml_libxml.h"
 #include "object.h"
diff --git a/plug-ins/vdx/vdx-xml.c b/plug-ins/vdx/vdx-xml.c
index e6d9f0a..6eff6a2 100644
--- a/plug-ins/vdx/vdx-xml.c
+++ b/plug-ins/vdx/vdx-xml.c
@@ -27,7 +27,6 @@
 #include <string.h>
 #include <libxml/tree.h>
 #include "intl.h"
-#include "message.h"
 #include "geometry.h"
 #include "filter.h"
 #include "object.h"
@@ -5184,7 +5183,7 @@ vdx_write_object(FILE *file, unsigned int depth, const void *p)
         break;
 
     default:
-         message_error(_("Can't write object %u"), Any->type);
+         g_warning("Can't write object %u", Any->type);
     }
     while(child)
     {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]