[gnome-shell] MessageTray: fix unexpanded height when receiving multiple telepathy messages



commit 9f48adcff9692ef6ac70df2e806d72841ded3b8c
Author: Giovanni Campagna <gcampagna src gnome org>
Date:   Sat Sep 8 18:54:50 2012 +0200

    MessageTray: fix unexpanded height when receiving multiple telepathy messages
    
    ClutterBinLayout is so amazingly broken: it uses the y_expand property to
    find out if the children needs to honor alignment/fill, but that property is
    "bubbled up" from the grand-children, so the notificationWidget would notice
    the y_expand on the notificationBin (necessary to make the layout manager on
    notificationWidget honor the alignment property for the bin), and would
    receive the full height of the MessageTray actor from the parent's layout manager,
    resulting in a notificationWidget shifting up, with the notification detached
    from the screen.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=683628

 js/ui/messageTray.js |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 614842e..481161a 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1379,7 +1379,9 @@ const MessageTray = new Lang.Class({
         this.actor.connect('notify::hover', Lang.bind(this, this._onTrayHoverChanged));
 
         this._notificationWidget = new St.Widget({ name: 'notification-container',
+                                                   y_align: Clutter.ActorAlign.START,
                                                    x_align: Clutter.ActorAlign.CENTER,
+                                                   y_expand: true,
                                                    x_expand: true,
                                                    layout_manager: new Clutter.BinLayout() });
         this.actor.add_actor(this._notificationWidget);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]