[epiphany] Use the new EphyHistoryService::urls-visited signal



commit c81e0a41799e891ae7cd73fb074af1956af6d9e0
Author: Claudio Saavedra <csaavedra igalia com>
Date:   Fri Sep 7 10:17:08 2012 +0300

    Use the new EphyHistoryService::urls-visited signal
    
    Since both the frecent store and the history window don't need to be
    updated immediately after a url is visited, we can use ::urls-visited
    instead. The advantage of this is that we reduce considerably the load
    when updating both models when loading many pages at the time,
    specially during startup.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=683550

 lib/widgets/ephy-frecent-store.c |   10 ++++------
 src/ephy-history-window.c        |    8 +++-----
 2 files changed, 7 insertions(+), 11 deletions(-)
---
diff --git a/lib/widgets/ephy-frecent-store.c b/lib/widgets/ephy-frecent-store.c
index bf3d9ec..8ea1a48 100644
--- a/lib/widgets/ephy-frecent-store.c
+++ b/lib/widgets/ephy-frecent-store.c
@@ -129,10 +129,8 @@ ephy_frecent_store_fetch_urls (EphyFrecentStore *store,
 }
 
 static gboolean
-on_visit_url_cb (EphyHistoryService *service,
-                 char *url,
-                 EphyHistoryPageVisitType visit_type,
-                 EphyFrecentStore *store)
+on_urls_visited_cb (EphyHistoryService *service,
+                    EphyFrecentStore *store)
 {
   ephy_frecent_store_fetch_urls (store, service);
 
@@ -254,8 +252,8 @@ setup_history_service (EphyFrecentStore *store)
 
   ephy_frecent_store_fetch_urls (store, service);
 
-  g_signal_connect_after (service, "visit-url",
-                    G_CALLBACK (on_visit_url_cb), store);
+  g_signal_connect (service, "urls-visited",
+                    G_CALLBACK (on_urls_visited_cb), store);
   g_signal_connect (service, "cleared",
                     G_CALLBACK (on_cleared_cb), store);
   g_signal_connect (service, "url-title-changed",
diff --git a/src/ephy-history-window.c b/src/ephy-history-window.c
index 7e42f76..8b03b69 100644
--- a/src/ephy-history-window.c
+++ b/src/ephy-history-window.c
@@ -1098,10 +1098,8 @@ filter_now (EphyHistoryWindow *editor,
 }
 
 static gboolean
-on_visit_url_cb (EphyHistoryService *service,
-		 gchar *url,
-		 EphyHistoryPageVisitType visit_type,
-		 EphyHistoryWindow *editor)
+on_urls_visited_cb (EphyHistoryService *service,
+		    EphyHistoryWindow *editor)
 {
 	filter_now (editor, TRUE, TRUE);
 
@@ -1297,7 +1295,7 @@ ephy_history_window_constructed (GObject *object)
 	filter_now (editor, TRUE, TRUE);
 
 	g_signal_connect_after (editor->priv->history_service,
-				"visit-url", G_CALLBACK (on_visit_url_cb),
+				"urls-visited", G_CALLBACK (on_urls_visited_cb),
 				editor);
 
 	if (G_OBJECT_CLASS (ephy_history_window_parent_class)->constructed)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]