[gdm] slave: don't prematurely set is_running to FALSE
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gdm] slave: don't prematurely set is_running to FALSE
- Date: Thu, 6 Sep 2012 17:55:19 +0000 (UTC)
commit 360772d6c9f1b3e099c19271ca12443d72fa799d
Author: Ray Strode <rstrode redhat com>
Date: Thu Sep 6 13:51:45 2012 -0400
slave: don't prematurely set is_running to FALSE
When the session ends we
1) set the session id to NULL
2) set is_running to FALSE
3) call gdm_slave_stop which
4) runs the PostSesssion script if is_running is true
5) sets is_running to FALSE
4) will always fail because of 2, and 2 is unnecessary because of 5.
This commit defers settings is_running to false until gdm_session_stop.
Spotted by Gert Kulyk
https://bugzilla.gnome.org/show_bug.cgi?id=681888
daemon/gdm-simple-slave.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/daemon/gdm-simple-slave.c b/daemon/gdm-simple-slave.c
index 2af76c7..20671c8 100644
--- a/daemon/gdm-simple-slave.c
+++ b/daemon/gdm-simple-slave.c
@@ -229,7 +229,6 @@ on_session_exited (GdmSession *session,
int exit_code,
GdmSimpleSlave *slave)
{
- slave->priv->session_is_running = FALSE;
g_object_set (GDM_SLAVE (slave), "session-id", NULL, NULL);
g_debug ("GdmSimpleSlave: session exited with code %d\n", exit_code);
@@ -241,7 +240,6 @@ on_session_died (GdmSession *session,
int signal_number,
GdmSimpleSlave *slave)
{
- slave->priv->session_is_running = FALSE;
g_object_set (GDM_SLAVE (slave), "session-id", NULL, NULL);
g_debug ("GdmSimpleSlave: session died with signal %d, (%s)",
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]