[gnome-shell] shell-gtk-embed: Fix NULL pointer dereference



commit f563fb124ec9dae29695daefba6f543981f5f36d
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Sun Mar 25 07:07:15 2012 -0300

    shell-gtk-embed: Fix NULL pointer dereference
    
    Clutter will try to unmap during a dispose if we have a parent, so if we
    set our own actor to NULL before the chain up, we're going to attempt to
    unmap our own NULL actor. Fix that by swapping the order in which we
    chain up.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=672790

 src/shell-gtk-embed.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/shell-gtk-embed.c b/src/shell-gtk-embed.c
index 8120e1e..2232919 100644
--- a/src/shell-gtk-embed.c
+++ b/src/shell-gtk-embed.c
@@ -223,9 +223,9 @@ shell_gtk_embed_dispose (GObject *object)
 {
   ShellGtkEmbed *embed = SHELL_GTK_EMBED (object);
 
-  shell_gtk_embed_set_window (embed, NULL);
-
   G_OBJECT_CLASS (shell_gtk_embed_parent_class)->dispose (object);
+
+  shell_gtk_embed_set_window (embed, NULL);
 }
 
 static void



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]