[evolution-data-server/gnome-3-6] CamelIMAPXServer: Make sure all disabled bits have a comment.
- From: Matthew Barnes <mbarnes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server/gnome-3-6] CamelIMAPXServer: Make sure all disabled bits have a comment.
- Date: Tue, 23 Oct 2012 17:13:50 +0000 (UTC)
commit b7e37966349e5f95497134970d2daa17e53069e9
Author: Matthew Barnes <mbarnes redhat com>
Date: Tue Oct 23 10:57:07 2012 -0400
CamelIMAPXServer: Make sure all disabled bits have a comment.
Normally I throw away all disabled-with-no-explanation-why code chunks,
but in this case they all seem related, so clarify that in the code.
(cherry picked from commit 0fa4740592cf6aa06a552e4b8af724083e35f404)
camel/camel-imapx-server.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/camel/camel-imapx-server.c b/camel/camel-imapx-server.c
index 58e7eb5..c4665f1 100644
--- a/camel/camel-imapx-server.c
+++ b/camel/camel-imapx-server.c
@@ -3014,7 +3014,7 @@ imapx_command_select_done (CamelIMAPXServer *is,
if (is->uidvalidity && is->uidvalidity != ((CamelIMAPXSummary *) cfolder->summary)->validity)
invalidate_local_cache (ifolder, is->uidvalidity);
-#if 0
+#if 0 /* see comment for disabled bits in imapx_job_refresh_info_start() */
/* This should trigger a new messages scan */
if (is->exists != is->select_folder->summary->root_view->total_count)
g_warning (
@@ -4988,8 +4988,8 @@ imapx_job_refresh_info_start (CamelIMAPXJob *job,
job->cancellable, &job->error))
goto done;
-#if 0 /* There are issues with this still; continue with the buggy behaviour
- where we issue STATUS on the current folder, for now...*/
+#if 0 /* There are issues with this still; continue with the buggy
+ * behaviour where we issue STATUS on the current folder, for now. */
if (is->select_folder == folder)
is_selected = TRUE;
#endif
@@ -5020,7 +5020,7 @@ imapx_job_refresh_info_start (CamelIMAPXJob *job,
if (!need_rescan) {
CamelIMAPXCommand *ic;
- #if 0
+ #if 0 /* see comment for disabled bits above */
if (is_selected) {
/* We may not issue STATUS on the current folder. Use SELECT or NOOP instead. */
if (0 /* server needs SELECT not just NOOP */) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]