[gupnp-av/wip/didl-lite-fragments: 17/19] A note for later.



commit 86e32cd473459cd4214b4775d94d8c83fd755aae
Author: Krzesimir Nowak <krnowak openismus com>
Date:   Tue Oct 23 14:20:55 2012 +0200

    A note for later.
    
    I have to reread this part of code. I wonder if it won't crash in the
    same way as it was crashing in apply_temporary_*() functions.

 libgupnp-av/gupnp-didl-lite-object.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/libgupnp-av/gupnp-didl-lite-object.c b/libgupnp-av/gupnp-didl-lite-object.c
index bb335b5..d1768e4 100644
--- a/libgupnp-av/gupnp-didl-lite-object.c
+++ b/libgupnp-av/gupnp-didl-lite-object.c
@@ -2981,6 +2981,7 @@ apply_modification (GUPnPDIDLLiteObject *object,
                     DocNode             *modified)
 {
         GUPnPDIDLLiteObjectPrivate *priv = object->priv;
+        /* I guess we should copy the modified->node first. */
         xmlNodePtr old = xmlReplaceNode (priv->xml_node, modified->node);
 
         if (old == NULL)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]