[grilo-plugins] tmdb: Don't free request errors too early.
- From: Mathias Hasselmann <hasselmm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [grilo-plugins] tmdb: Don't free request errors too early.
- Date: Wed, 17 Oct 2012 13:13:22 +0000 (UTC)
commit b75029d4d398fa06284aa9384552632537e5e454
Author: Mathias Hasselmann <mathias openismus com>
Date: Wed Oct 17 15:11:51 2012 +0200
tmdb: Don't free request errors too early.
We accessed already freed GErrors when TMDB complained about bad API keys.
src/tmdb/grl-tmdb.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/tmdb/grl-tmdb.c b/src/tmdb/grl-tmdb.c
index 8d4505c..c4b32a9 100644
--- a/src/tmdb/grl-tmdb.c
+++ b/src/tmdb/grl-tmdb.c
@@ -413,7 +413,7 @@ register_metadata_key (GrlRegistry *registry,
static void
resolve_closure_callback (ResolveClosure *closure,
- GError *outer_error)
+ const GError *outer_error)
{
GError *error = NULL;
@@ -421,7 +421,6 @@ resolve_closure_callback (ResolveClosure *closure,
error = g_error_new_literal (GRL_CORE_ERROR,
GRL_CORE_ERROR_RESOLVE_FAILED,
outer_error->message);
- g_error_free (outer_error);
}
closure->rs->callback (GRL_SOURCE (closure->self),
@@ -817,6 +816,7 @@ on_search_ready (GObject *source,
&error)) {
resolve_closure_callback (closure, error);
resolve_closure_free (closure);
+ g_error_free (error);
return;
}
@@ -836,6 +836,7 @@ on_search_ready (GObject *source,
"Remote data did not contain valid ID");
resolve_closure_callback (closure, error);
resolve_closure_free (closure);
+ g_error_free (error);
return;
}
@@ -1005,6 +1006,8 @@ on_configuration_ready (GObject *source,
resolve_closure_callback (pending_closure, error);
resolve_closure_free (pending_closure);
}
+
+ g_error_free (error);
return;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]