[gnome-boxes] libvirt-machine: Only gather stats in running state
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes] libvirt-machine: Only gather stats in running state
- Date: Mon, 15 Oct 2012 12:47:59 +0000 (UTC)
commit f2bdae3fdb98e00d10476e1b514c925389fefa8f
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Wed Oct 10 19:22:27 2012 +0300
libvirt-machine: Only gather stats in running state
There is no need to keep querying libvirt for stats/info on domain if
domain is not running. Doing so only wastes host resources and even
result in console getting spammed with warnings when host is under heavy
load.
https://bugzilla.gnome.org/show_bug.cgi?id=685900
src/libvirt-machine.vala | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/libvirt-machine.vala b/src/libvirt-machine.vala
index a435935..43b63ef 100644
--- a/src/libvirt-machine.vala
+++ b/src/libvirt-machine.vala
@@ -89,6 +89,7 @@ private class Boxes.LibvirtMachine: Boxes.Machine {
case DomainState.RUNNING:
case DomainState.BLOCKED:
state = MachineState.RUNNING;
+ set_stats_enable (true);
break;
case DomainState.PAUSED:
state = MachineState.PAUSED;
@@ -132,8 +133,11 @@ private class Boxes.LibvirtMachine: Boxes.Machine {
Signal.connect_object(domain, "pmsuspended", (GLib.Callback) LibvirtMachine.pmsuspended_callback, this, 0);
}
notify["state"].connect (() => {
- if (state == MachineState.RUNNING)
+ if (state == MachineState.RUNNING) {
reconnect_display ();
+ set_stats_enable (true);
+ } else
+ set_stats_enable (false);
});
update_domain_config ();
@@ -142,7 +146,6 @@ private class Boxes.LibvirtMachine: Boxes.Machine {
if (state != MachineState.STOPPED)
load_screenshot ();
set_screenshot_enable (true);
- set_stats_enable (true);
}
// This is done as a method and not a lambda as we don't want a hard build
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]