[gnome-shell] loginDialog: Use the same focus root for dialog and ctrl-alt-tab
- From: Florian MÃllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] loginDialog: Use the same focus root for dialog and ctrl-alt-tab
- Date: Thu, 11 Oct 2012 17:05:34 +0000 (UTC)
commit 3abfcda8b5998d10caa129c09422dd2c25874451
Author: Florian MÃllner <fmuellner gnome org>
Date: Wed Oct 10 22:07:02 2012 +0200
loginDialog: Use the same focus root for dialog and ctrl-alt-tab
Adding a group to the Ctrl-Alt-Tab popup will also add it to the
focus manager. Due to that, we currently end up with two focus
groups added for the login dialog - an explicit one for the entire
dialog, and an implicit one for the main content group.
When doing keynav, we ascend in the widget hierarchy from the
currently focused actor until we find a valid focus root, so
adding a children of the dialog as focus root breaks keynav to
any actors that are not inside the main content group.
The simple fix is to use the same group in both cases.
https://bugzilla.gnome.org/show_bug.cgi?id=684730
js/gdm/loginDialog.js | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js
index 17a4ad6..7ea93ba 100644
--- a/js/gdm/loginDialog.js
+++ b/js/gdm/loginDialog.js
@@ -1211,7 +1211,7 @@ const LoginDialog = new Lang.Class({
},
_onOpened: function() {
- Main.ctrlAltTabManager.addGroup(this.contentLayout,
+ Main.ctrlAltTabManager.addGroup(this.dialogLayout,
_("Login Window"),
'dialog-password',
{ sortGroup: CtrlAltTab.SortGroup.MIDDLE });
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]