[gnome-boxes] wizard: Unselect entry when going from URL to main page
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes] wizard: Unselect entry when going from URL to main page
- Date: Thu, 11 Oct 2012 12:21:19 +0000 (UTC)
commit d7fdde7c582db8c0c1da469d287515251c5fce0b
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date: Mon Oct 8 23:53:24 2012 +0300
wizard: Unselect entry when going from URL to main page
If you follow these steps, 'Continue' becomes sensitive:
1. Type something in the entry on URL page
2. Go back to main page
3. Go to URL page
4. Remove all text from entry
5. Repeat 2 and 3 again
This patch fixes the problem by simply unsetting the current selection
when going back from URL to main page. IMHO this makes sense anyways
since on main page the URL is not shown so user doesn't know what would
'Continue' imply. Note that with this patch, 'Continue' becomes
sensitive again if you go to URL page and there is text entered already
in there.
NOTE: We probably should be doing some more checks on URLs before
enabling the 'Continue' button rather than simply checking non-zero
length string.
https://bugzilla.gnome.org/show_bug.cgi?id=684220
src/wizard-source.vala | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/wizard-source.vala b/src/wizard-source.vala
index 3cd3756..ba1300e 100644
--- a/src/wizard-source.vala
+++ b/src/wizard-source.vala
@@ -136,6 +136,7 @@ private class Boxes.WizardSource: GLib.Object {
notebook.append_page (url_menubox, null);
hbox = add_entry (url_menubox, () => {
+ selected = null;
page = SourcePage.MAIN;
return false;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]