[gtk+] gtk_css_value_bg_size_equal: actually compare contain values
- From: Matthias Clasen <matthiasc src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [gtk+] gtk_css_value_bg_size_equal: actually compare contain values
 
- Date: Fri, 30 Nov 2012 04:27:37 +0000 (UTC)
 
commit bf26d46cb21d0f37e1497ac33086d9d271ae19e8
Author: Matthias Clasen <mclasen redhat com>
Date:   Thu Nov 29 22:09:31 2012 -0500
    gtk_css_value_bg_size_equal: actually compare contain values
    
    Due to a copy-paste error, the code failed to compare the
    contain members of value1 and value2.
    
    This was found by Coverity.
 gtk/gtkcssbgsizevalue.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtkcssbgsizevalue.c b/gtk/gtkcssbgsizevalue.c
index a34b3c1..662ceb7 100644
--- a/gtk/gtkcssbgsizevalue.c
+++ b/gtk/gtkcssbgsizevalue.c
@@ -74,7 +74,7 @@ gtk_css_value_bg_size_equal (const GtkCssValue *value1,
                              const GtkCssValue *value2)
 {
   return value1->cover == value2->cover &&
-         value2->contain == value2->contain &&
+         value1->contain == value2->contain &&
          (value1->x == value2->x ||
           (value1->x != NULL && value2->x != NULL &&
            _gtk_css_value_equal (value1->x, value2->x))) &&
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]