[gnome-shell] appDisplay: don't increment counter if we didn't add a category
- From: Cosimo Cecchi <cosimoc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] appDisplay: don't increment counter if we didn't add a category
- Date: Fri, 30 Nov 2012 00:24:09 +0000 (UTC)
commit e58fbeea1756d199ed95b33b5a533597746b37a8
Author: Cosimo Cecchi <cosimoc gnome org>
Date: Thu Nov 29 19:21:41 2012 -0500
appDisplay: don't increment counter if we didn't add a category
Or we'll later try to jump to the wrong category when clicking on it.
js/ui/appDisplay.js | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 300c7e7..851a511 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -223,7 +223,7 @@ const ViewByCategories = new Lang.Class({
this._loadCategory(dir, apps);
if (apps.length == 0)
- return;
+ return false;
}
let button = new St.Button({ label: GLib.markup_escape_text (name, -1),
@@ -244,6 +244,7 @@ const ViewByCategories = new Lang.Class({
}
this._categoryBox.add(button, { expand: true, x_fill: true, y_fill: false });
+ return true;
},
_removeAll: function() {
@@ -269,8 +270,9 @@ const ViewByCategories = new Lang.Class({
var dir = iter.get_directory();
if (dir.get_is_nodisplay())
continue;
- this._addCategory(dir.get_name(), i, dir);
- i++;
+
+ if (this._addCategory(dir.get_name(), i, dir))
+ i++;
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]