[geocode-glib] lib: Simplify _new_for_params() internally
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geocode-glib] lib: Simplify _new_for_params() internally
- Date: Sun, 25 Nov 2012 22:14:35 +0000 (UTC)
commit 33af5cdce76919f4763c066a48639d7c06644e92
Author: Bastien Nocera <hadess hadess net>
Date: Sun Nov 25 22:34:51 2012 +0100
lib: Simplify _new_for_params() internally
geocode-glib/geocode-forward.c | 21 +++++++--------------
1 files changed, 7 insertions(+), 14 deletions(-)
---
diff --git a/geocode-glib/geocode-forward.c b/geocode-glib/geocode-forward.c
index c670d48..c1b0904 100644
--- a/geocode-glib/geocode-forward.c
+++ b/geocode-glib/geocode-forward.c
@@ -141,29 +141,22 @@ static struct {
static void
geocode_forward_fill_params (GeocodeForward *forward,
- GHashTable *params,
- gboolean value_is_str)
+ GHashTable *params)
{
guint i;
for (i = 0; i < G_N_ELEMENTS (attrs_map); i++) {
const char *str;
+ GValue *value;
if (attrs_map[i].gc_attr == NULL)
continue;
- if (value_is_str == FALSE) {
- GValue *value;
-
- value = g_hash_table_lookup (params, attrs_map[i].tp_attr);
- if (value == NULL)
- continue;
-
- str = g_value_get_string (value);
- } else {
- str = g_hash_table_lookup (params, attrs_map[i].tp_attr);
- }
+ value = g_hash_table_lookup (params, attrs_map[i].tp_attr);
+ if (value == NULL)
+ continue;
+ str = g_value_get_string (value);
if (str == NULL)
continue;
@@ -200,7 +193,7 @@ geocode_forward_new_for_params (GHashTable *params)
}
forward = g_object_new (GEOCODE_TYPE_FORWARD, NULL);
- geocode_forward_fill_params (forward, params, FALSE);
+ geocode_forward_fill_params (forward, params);
geocode_forward_set_answer_count (forward, 1);
return forward;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]