[anjuta] anjuta-window: Don't call gtk_widget_show_all when setting up widget.
- From: Sebastien Granjoux <sgranjoux src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [anjuta] anjuta-window: Don't call gtk_widget_show_all when setting up widget.
- Date: Sun, 11 Nov 2012 21:52:40 +0000 (UTC)
commit 63116fe00638d857f6bb4b7b3ffd3729c8c6f4ae
Author: Carl-Anton Ingmarsson <ca ingmarsson gmail com>
Date: Sun Nov 11 21:21:31 2012 +0100
anjuta-window: Don't call gtk_widget_show_all when setting up widget.
Just call gtk_widget_show instead. Calling gtk_widget_show_all breaks widgets that
not always want to show all children.
Also fixup the document-manager, git and snippets-manager plugins which relied on
gtk_widget_show_all to be called by anjuta-window.c.
https://bugzilla.gnome.org/show_bug.cgi?id=687327
plugins/document-manager/plugin.c | 1 +
plugins/git/plugin.c | 2 ++
plugins/snippets-manager/plugin.c | 1 +
src/anjuta-window.c | 2 +-
4 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/plugins/document-manager/plugin.c b/plugins/document-manager/plugin.c
index 665e46f..3179b56 100644
--- a/plugins/document-manager/plugin.c
+++ b/plugins/document-manager/plugin.c
@@ -1663,6 +1663,7 @@ activate_plugin (AnjutaPlugin *plugin)
ui = dplugin->ui;
docman = anjuta_docman_new (dplugin);
+ gtk_widget_show (docman);
dplugin->docman = docman;
ANJUTA_DOCMAN(docman)->shell = anjuta_plugin_get_shell(plugin);
diff --git a/plugins/git/plugin.c b/plugins/git/plugin.c
index 09207f4..26296da 100644
--- a/plugins/git/plugin.c
+++ b/plugins/git/plugin.c
@@ -719,10 +719,12 @@ git_activate_plugin (AnjutaPlugin *plugin)
anjuta_dock_set_command_bar (ANJUTA_DOCK (git_plugin->dock),
ANJUTA_COMMAND_BAR (git_plugin->command_bar));
+ gtk_widget_show_all (git_plugin->command_bar_window);
anjuta_shell_add_widget (plugin->shell, git_plugin->command_bar_window,
"GitCommandBar", _("Git Tasks"), "git-tasks",
ANJUTA_SHELL_PLACEMENT_LEFT, NULL);
+ gtk_widget_show_all (git_plugin->dock_window);
anjuta_shell_add_widget (plugin->shell, git_plugin->dock_window, "GitDock",
_("Git"), "git-plugin", ANJUTA_SHELL_PLACEMENT_CENTER,
NULL);
diff --git a/plugins/snippets-manager/plugin.c b/plugins/snippets-manager/plugin.c
index 308b4b3..d56c423 100644
--- a/plugins/snippets-manager/plugin.c
+++ b/plugins/snippets-manager/plugin.c
@@ -300,6 +300,7 @@ snippets_manager_activate (AnjutaPlugin * plugin)
snippets_browser_load (snippets_manager_plugin->snippets_browser,
snippets_manager_plugin->snippets_db,
snippets_manager_plugin->snippets_interaction);
+ gtk_widget_show_all (snippets_manager_plugin->snippets_browser);
anjuta_shell_add_widget_custom (plugin->shell,
GTK_WIDGET (snippets_manager_plugin->snippets_browser),
"snippets_browser",
diff --git a/src/anjuta-window.c b/src/anjuta-window.c
index 12afe30..1fb58c8 100644
--- a/src/anjuta-window.c
+++ b/src/anjuta-window.c
@@ -1227,7 +1227,7 @@ anjuta_window_setup_widget (AnjutaWindow* win,
g_signal_connect_after (G_OBJECT (widget), "destroy",
G_CALLBACK (on_widget_destroy), win);
- gtk_widget_show_all (item);
+ gtk_widget_show (item);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]