GNOME.org
 

[grilo-plugins] all: Remove ->get_caps stubs

commit 33f410586efff2c8a089068c981c7db54dff438b
Author: Bastien Nocera <hadess hadess net>
Date:   Thu Nov 1 23:15:05 2012 +0000

    all: Remove ->get_caps stubs
    
    The default implementation does the exact same thing, and this
    saves us some code.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=673491
    
    Signed-off-by: Juan A. Suarez Romero <jasuarez igalia com>

 src/apple-trailers/grl-apple-trailers.c |   16 ----------------
 src/bliptv/grl-bliptv.c                 |   16 ----------------
 src/bookmarks/grl-bookmarks.c           |   16 ----------------
 src/flickr/grl-flickr.c                 |   16 ----------------
 src/jamendo/grl-jamendo.c               |   16 ----------------
 src/optical-media/grl-optical-media.c   |   19 -------------------
 src/podcasts/grl-podcasts.c             |   16 ----------------
 src/shoutcast/grl-shoutcast.c           |   16 ----------------
 src/upnp/grl-upnp.c                     |   16 ----------------
 src/vimeo/grl-vimeo.c                   |   16 ----------------
 src/youtube/grl-youtube.c               |   16 ----------------
 11 files changed, 0 insertions(+), 179 deletions(-)
---
diff --git a/src/apple-trailers/grl-apple-trailers.c b/src/apple-trailers/grl-apple-trailers.c
index 5f82b36..f1aab9a 100644
--- a/src/apple-trailers/grl-apple-trailers.c
+++ b/src/apple-trailers/grl-apple-trailers.c
@@ -94,9 +94,6 @@ static void grl_apple_trailers_source_browse (GrlSource *source,
 static void grl_apple_trailers_source_cancel (GrlSource *source,
                                               guint operation_id);
 
-static GrlCaps *grl_apple_trailers_source_get_caps (GrlSource *source,
-                                                    GrlSupportedOps operation);
-
 /* =================== Apple Trailers Plugin  =============== */
 
 gboolean
@@ -224,7 +221,6 @@ grl_apple_trailers_source_class_init (GrlAppleTrailersSourceClass * klass)
   source_class->cancel = grl_apple_trailers_source_cancel;
   source_class->supported_keys = grl_apple_trailers_source_supported_keys;
   source_class->browse = grl_apple_trailers_source_browse;
-  source_class->get_caps = grl_apple_trailers_source_get_caps;
 
   g_object_class_install_property (g_class,
                                    PROP_HD,
@@ -620,15 +616,3 @@ grl_apple_trailers_source_cancel (GrlSource *source, guint operation_id)
     op_data->cancelled = TRUE;
   }
 }
-
-static GrlCaps *
-grl_apple_trailers_source_get_caps (GrlSource *source,
-                                    GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/bliptv/grl-bliptv.c b/src/bliptv/grl-bliptv.c
index 202c396..ea542d4 100644
--- a/src/bliptv/grl-bliptv.c
+++ b/src/bliptv/grl-bliptv.c
@@ -93,9 +93,6 @@ gboolean grl_bliptv_plugin_init (GrlRegistry *registry,
 
 static const GList *grl_bliptv_source_supported_keys (GrlSource *source);
 
-static GrlCaps * grl_bliptv_source_get_caps (GrlSource *source,
-                                             GrlSupportedOps operation);
-
 static void grl_bliptv_source_browse (GrlSource *source,
                                       GrlSourceBrowseSpec *bs);
 
@@ -165,7 +162,6 @@ grl_bliptv_source_class_init (GrlBliptvSourceClass *klass)
   object_class->finalize = grl_bliptv_source_finalize;
 
   source_class->supported_keys = grl_bliptv_source_supported_keys;
-  source_class->get_caps = grl_bliptv_source_get_caps;
   source_class->cancel = grl_bliptv_source_cancel;
   source_class->browse = grl_bliptv_source_browse;
   source_class->search = grl_bliptv_source_search;
@@ -499,15 +495,3 @@ grl_bliptv_source_cancel (GrlSource *source, guint operation_id)
   grl_operation_set_data (operation_id, NULL);
   bliptv_operation_free (op);
 }
-
-static GrlCaps *
-grl_bliptv_source_get_caps (GrlSource *source,
-                            GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/bookmarks/grl-bookmarks.c b/src/bookmarks/grl-bookmarks.c
index f2545e5..3a1b1b7 100644
--- a/src/bookmarks/grl-bookmarks.c
+++ b/src/bookmarks/grl-bookmarks.c
@@ -180,9 +180,6 @@ static gboolean grl_bookmarks_source_notify_change_start (GrlSource *source,
 static gboolean grl_bookmarks_source_notify_change_stop (GrlSource *source,
                                                          GError **error);
 
-static GrlCaps * grl_bookmarks_source_get_caps (GrlSource *source,
-                                                GrlSupportedOps operation);
-
  /* =================== Bookmarks Plugin  =============== */
 
  static gboolean
@@ -249,7 +246,6 @@ static GrlCaps * grl_bookmarks_source_get_caps (GrlSource *source,
 
    source_class->supported_operations = grl_bookmarks_source_supported_operations;
    source_class->supported_keys = grl_bookmarks_source_supported_keys;
-   source_class->get_caps = grl_bookmarks_source_get_caps;
    source_class->browse = grl_bookmarks_source_browse;
    source_class->search = grl_bookmarks_source_search;
    source_class->query = grl_bookmarks_source_query;
@@ -932,15 +928,3 @@ grl_bookmarks_source_notify_change_stop (GrlSource *source,
 
   return TRUE;
 }
-
-static GrlCaps *
-grl_bookmarks_source_get_caps (GrlSource *source,
-                               GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/flickr/grl-flickr.c b/src/flickr/grl-flickr.c
index b2a4129..79c49e5 100644
--- a/src/flickr/grl-flickr.c
+++ b/src/flickr/grl-flickr.c
@@ -99,9 +99,6 @@ gboolean grl_flickr_plugin_init (GrlRegistry *registry,
 
 static const GList *grl_flickr_source_supported_keys (GrlSource *source);
 
-static GrlCaps * grl_flickr_source_get_caps (GrlSource *source,
-                                             GrlSupportedOps operation);
-
 static void grl_flickr_source_browse (GrlSource *source,
                                       GrlSourceBrowseSpec *bs);
 
@@ -219,7 +216,6 @@ grl_flickr_source_class_init (GrlFlickrSourceClass * klass)
   gobject_class->finalize = grl_flickr_source_finalize;
 
   source_class->supported_keys = grl_flickr_source_supported_keys;
-  source_class->get_caps = grl_flickr_source_get_caps;
   source_class->browse = grl_flickr_source_browse;
   source_class->resolve = grl_flickr_source_resolve;
   source_class->search = grl_flickr_source_search;
@@ -761,15 +757,3 @@ grl_flickr_source_search (GrlSource *source,
                                od);
   }
 }
-
-static GrlCaps *
-grl_flickr_source_get_caps (GrlSource *source,
-                            GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/jamendo/grl-jamendo.c b/src/jamendo/grl-jamendo.c
index 3fe3f93..b7bffbc 100644
--- a/src/jamendo/grl-jamendo.c
+++ b/src/jamendo/grl-jamendo.c
@@ -177,9 +177,6 @@ gboolean grl_jamendo_plugin_init (GrlRegistry *registry,
 
 static const GList *grl_jamendo_source_supported_keys (GrlSource *source);
 
-static GrlCaps *grl_jamendo_source_get_caps (GrlSource *source,
-                                             GrlSupportedOps operation);
-
 static void grl_jamendo_source_resolve (GrlSource *source,
                                         GrlSourceResolveSpec *rs);
 
@@ -259,7 +256,6 @@ grl_jamendo_source_class_init (GrlJamendoSourceClass * klass)
 
   source_class->cancel = grl_jamendo_source_cancel;
   source_class->supported_keys = grl_jamendo_source_supported_keys;
-  source_class->get_caps = grl_jamendo_source_get_caps;
   source_class->resolve = grl_jamendo_source_resolve;
   source_class->browse = grl_jamendo_source_browse;
   source_class->query = grl_jamendo_source_query;
@@ -1363,15 +1359,3 @@ grl_jamendo_source_cancel (GrlSource *source, guint operation_id)
     xpe->cancelled = TRUE;
   }
 }
-
-static GrlCaps *
-grl_jamendo_source_get_caps (GrlSource *source,
-                             GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/optical-media/grl-optical-media.c b/src/optical-media/grl-optical-media.c
index 7727998..0b7c47a 100644
--- a/src/optical-media/grl-optical-media.c
+++ b/src/optical-media/grl-optical-media.c
@@ -71,9 +71,6 @@ gboolean grl_optical_media_plugin_init (GrlRegistry *registry,
 
 static const GList *grl_optical_media_source_supported_keys (GrlSource *source);
 
-static GrlCaps *grl_optical_media_source_get_caps (GrlSource *source,
-                                                   GrlSupportedOps operation);
-
 static void grl_optical_media_source_browse (GrlSource *source,
                                              GrlSourceBrowseSpec *bs);
 
@@ -139,7 +136,6 @@ grl_optical_media_source_class_init (GrlOpticalMediaSourceClass * klass)
 
   source_class->supported_keys = grl_optical_media_source_supported_keys;
   source_class->cancel = grl_optical_media_source_cancel;
-  source_class->get_caps = grl_optical_media_source_get_caps;
   source_class->browse = grl_optical_media_source_browse;
 
   g_type_class_add_private (klass, sizeof (GrlOpticalMediaSourcePrivate));
@@ -551,18 +547,3 @@ grl_optical_media_source_cancel (GrlSource *source, guint operation_id)
     g_cancellable_cancel (cancellable);
   }
 }
-
-static GrlCaps *
-grl_optical_media_source_get_caps (GrlSource *source,
-                                   GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  /* Nothing very special for now */
-
-  if (caps == NULL) {
-    caps = grl_caps_new ();
-  }
-
-  return caps;
-}
diff --git a/src/podcasts/grl-podcasts.c b/src/podcasts/grl-podcasts.c
index 6a2711c..191ae8e 100644
--- a/src/podcasts/grl-podcasts.c
+++ b/src/podcasts/grl-podcasts.c
@@ -237,9 +237,6 @@ static void grl_podcasts_source_finalize (GObject *plugin);
 
 static const GList *grl_podcasts_source_supported_keys (GrlSource *source);
 
-static GrlCaps * grl_podcasts_source_get_caps (GrlSource *source,
-                                               GrlSupportedOps operation);
-
 static void grl_podcasts_source_browse (GrlSource *source,
                                         GrlSourceBrowseSpec *bs);
 
@@ -337,7 +334,6 @@ grl_podcasts_source_class_init (GrlPodcastsSourceClass * klass)
   gobject_class->finalize = grl_podcasts_source_finalize;
 
   source_class->supported_keys = grl_podcasts_source_supported_keys;
-  source_class->get_caps = grl_podcasts_source_get_caps;
   source_class->browse = grl_podcasts_source_browse;
   source_class->search = grl_podcasts_source_search;
   source_class->query = grl_podcasts_source_query;
@@ -1841,15 +1837,3 @@ grl_podcasts_source_notify_change_stop (GrlSource *source,
 
   return TRUE;
 }
-
-static GrlCaps *
-grl_podcasts_source_get_caps (GrlSource *source,
-                              GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/shoutcast/grl-shoutcast.c b/src/shoutcast/grl-shoutcast.c
index bb93114..2702604 100644
--- a/src/shoutcast/grl-shoutcast.c
+++ b/src/shoutcast/grl-shoutcast.c
@@ -100,9 +100,6 @@ gboolean grl_shoutcast_plugin_init (GrlRegistry *registry,
 
 static const GList *grl_shoutcast_source_supported_keys (GrlSource *source);
 
-static GrlCaps * grl_shoutcast_source_get_caps (GrlSource *source,
-                                                GrlSupportedOps operation);
-
 static void grl_shoutcast_source_resolve (GrlSource *source,
                                           GrlSourceResolveSpec *rs);
 
@@ -199,7 +196,6 @@ grl_shoutcast_source_class_init (GrlShoutcastSourceClass * klass)
 
   source_class->cancel = grl_shoutcast_source_cancel;
   source_class->supported_keys = grl_shoutcast_source_supported_keys;
-  source_class->get_caps = grl_shoutcast_source_get_caps;
   source_class->resolve = grl_shoutcast_source_resolve;
   source_class->browse = grl_shoutcast_source_browse;
   source_class->search = grl_shoutcast_source_search;
@@ -808,15 +804,3 @@ grl_shoutcast_source_cancel (GrlSource *source, guint operation_id)
     op_data->cancelled = TRUE;
   }
 }
-
-static GrlCaps *
-grl_shoutcast_source_get_caps (GrlSource *source,
-                               GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/upnp/grl-upnp.c b/src/upnp/grl-upnp.c
index 8f6eeb0..042f532 100644
--- a/src/upnp/grl-upnp.c
+++ b/src/upnp/grl-upnp.c
@@ -108,9 +108,6 @@ static const GList *grl_upnp_source_supported_keys (GrlSource *source);
 
 static GrlSupportedOps grl_upnp_source_supported_operations (GrlSource *source);
 
-static GrlCaps * grl_upnp_source_get_caps (GrlSource *source,
-                                           GrlSupportedOps operation);
-
 static void grl_upnp_source_browse (GrlSource *source,
                                     GrlSourceBrowseSpec *bs);
 
@@ -223,7 +220,6 @@ grl_upnp_source_class_init (GrlUpnpSourceClass * klass)
 
   source_class->supported_keys = grl_upnp_source_supported_keys;
   source_class->supported_operations = grl_upnp_source_supported_operations;
-  source_class->get_caps = grl_upnp_source_get_caps;
   source_class->browse = grl_upnp_source_browse;
   source_class->search = grl_upnp_source_search;
   source_class->query = grl_upnp_source_query;
@@ -1362,15 +1358,3 @@ grl_upnp_source_notify_change_stop (GrlSource *source,
 
   return TRUE;
 }
-
-static GrlCaps *
-grl_upnp_source_get_caps (GrlSource *source,
-                          GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/vimeo/grl-vimeo.c b/src/vimeo/grl-vimeo.c
index 68fd44d..21043ac 100644
--- a/src/vimeo/grl-vimeo.c
+++ b/src/vimeo/grl-vimeo.c
@@ -73,9 +73,6 @@ gboolean grl_vimeo_plugin_init (GrlRegistry *registry,
 
 static const GList *grl_vimeo_source_supported_keys (GrlSource *source);
 
-static GrlCaps * grl_vimeo_source_get_caps (GrlSource *source,
-                                            GrlSupportedOps operation);
-
 static void grl_vimeo_source_resolve (GrlSource *source,
                                       GrlSourceResolveSpec *rs);
 
@@ -170,7 +167,6 @@ grl_vimeo_source_class_init (GrlVimeoSourceClass * klass)
   GrlSourceClass *source_class = GRL_SOURCE_CLASS (klass);
 
   source_class->supported_keys = grl_vimeo_source_supported_keys;
-  source_class->get_caps = grl_vimeo_source_get_caps;
   source_class->resolve = grl_vimeo_source_resolve;
   source_class->search = grl_vimeo_source_search;
 
@@ -432,15 +428,3 @@ grl_vimeo_source_search (GrlSource *source,
 
   g_vimeo_videos_search (vimeo, ss->text, sd->page, search_cb, sd);
 }
-
-static GrlCaps *
-grl_vimeo_source_get_caps (GrlSource *source,
-                           GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
diff --git a/src/youtube/grl-youtube.c b/src/youtube/grl-youtube.c
index 53f182d..e37224c 100644
--- a/src/youtube/grl-youtube.c
+++ b/src/youtube/grl-youtube.c
@@ -194,9 +194,6 @@ static const GList *grl_youtube_source_supported_keys (GrlSource *source);
 
 static const GList *grl_youtube_source_slow_keys (GrlSource *source);
 
-static GrlCaps * grl_youtube_source_get_caps (GrlSource *source,
-                                              GrlSupportedOps operation);
-
 static void grl_youtube_source_search (GrlSource *source,
                                        GrlSourceSearchSpec *ss);
 
@@ -363,7 +360,6 @@ grl_youtube_source_class_init (GrlYoutubeSourceClass * klass)
 
   source_class->supported_keys = grl_youtube_source_supported_keys;
   source_class->slow_keys = grl_youtube_source_slow_keys;
-  source_class->get_caps = grl_youtube_source_get_caps;
   source_class->cancel = grl_youtube_source_cancel;
 
   source_class->search = grl_youtube_source_search;
@@ -1611,15 +1607,3 @@ grl_youtube_source_cancel (GrlSource *source,
     g_cancellable_cancel (cancellable);
   }
 }
-
-static GrlCaps *
-grl_youtube_source_get_caps (GrlSource *source,
-                             GrlSupportedOps operation)
-{
-  static GrlCaps *caps = NULL;
-
-  if (caps == NULL)
-    caps = grl_caps_new ();
-
-  return caps;
-}
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]