[gimp] Bug 676821 - No drag layers in "window layers", after commit...



commit 92a3944442aac649d3825f5186e441c6dfa9cbe2
Author: Michael Natterer <mitch gimp org>
Date:   Fri May 25 21:25:29 2012 +0200

    Bug 676821 - No drag layers in "window layers", after commit...
    
    Remove the button_release handler again, setting dnd_widget to NULL on
    container change is enough to fix the crash I've seen, I added the
    other handler just out of paranoia and apparently didn't test it.

 app/widgets/gimpcontainertreeview.c |   19 -------------------
 1 files changed, 0 insertions(+), 19 deletions(-)
---
diff --git a/app/widgets/gimpcontainertreeview.c b/app/widgets/gimpcontainertreeview.c
index d0329bb..eb097a1 100644
--- a/app/widgets/gimpcontainertreeview.c
+++ b/app/widgets/gimpcontainertreeview.c
@@ -103,9 +103,6 @@ static void          gimp_container_tree_view_selection_changed (GtkTreeSelectio
 static gboolean      gimp_container_tree_view_button_press      (GtkWidget                   *widget,
                                                                  GdkEventButton              *bevent,
                                                                  GimpContainerTreeView       *tree_view);
-static gboolean      gimp_container_tree_view_button_release    (GtkWidget                   *widget,
-                                                                 GdkEventButton              *bevent,
-                                                                 GimpContainerTreeView       *tree_view);
 static gboolean      gimp_container_tree_view_tooltip           (GtkWidget                   *widget,
                                                                  gint                         x,
                                                                  gint                         y,
@@ -545,9 +542,6 @@ gimp_container_tree_view_set_container (GimpContainerView *view,
           g_signal_handlers_disconnect_by_func (tree_view->view,
                                                 gimp_container_tree_view_button_press,
                                                 tree_view);
-          g_signal_handlers_disconnect_by_func (tree_view->view,
-                                                gimp_container_tree_view_button_release,
-                                                tree_view);
         }
     }
   else if (container)
@@ -574,9 +568,6 @@ gimp_container_tree_view_set_container (GimpContainerView *view,
       g_signal_connect (tree_view->view, "button-press-event",
                         G_CALLBACK (gimp_container_tree_view_button_press),
                         tree_view);
-      g_signal_connect (tree_view->view, "button-release-event",
-                        G_CALLBACK (gimp_container_tree_view_button_release),
-                        tree_view);
     }
 
   parent_view_iface->set_container (view, container);
@@ -1192,16 +1183,6 @@ gimp_container_tree_view_button_press (GtkWidget             *widget,
 }
 
 static gboolean
-gimp_container_tree_view_button_release (GtkWidget             *widget,
-                                         GdkEventButton        *bevent,
-                                         GimpContainerTreeView *tree_view)
-{
-  tree_view->priv->dnd_renderer = NULL;
-
-  return FALSE;
-}
-
-static gboolean
 gimp_container_tree_view_tooltip (GtkWidget             *widget,
                                   gint                   x,
                                   gint                   y,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]