[perl-Glib-Object-Introspection] Correctly place the linker flags when building the test libs



commit a089780f26d3b90b9345f1ab9ae76a53acf26ce5
Author: Torsten SchÃnfeld <kaffeetisch gmx de>
Date:   Tue May 22 22:02:37 2012 +0200

    Correctly place the linker flags when building the test libs
    
    Linker flags such as -lxxx need to come after the source files that make use of
    symbols in libxxx.so.
    
    https://rt.cpan.org/Ticket/Display.html?id=77341

 Makefile.PL |   10 +++++-----
 NEWS        |    5 +++++
 2 files changed, 10 insertions(+), 5 deletions(-)
---
diff --git a/Makefile.PL b/Makefile.PL
index 5c5ed39..46089e2 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -115,11 +115,10 @@ sub compile_test_libraries {
     my %gio_flags = ExtUtils::PkgConfig->find ('gio-2.0');
     my %glib_flags = ExtUtils::PkgConfig->find ('glib-2.0');
 
-    # FIXME: Why is --no-as-needed necessary?
-       !system (qq(gcc -shared -fPIC -Wl,--no-as-needed -g \\
-                   $cairo_flags{cflags} $cairo_flags{libs} \\
-                   $gio_flags{cflags} $gio_flags{libs} \\
+       !system (qq(gcc -shared -fPIC -g \\
+                   $cairo_flags{cflags} $gio_flags{cflags} \\
                    $testsdir/regress.c \\
+                   $cairo_flags{libs} $gio_flags{libs} \\
                    -o libregress.so 1>/dev/null 2>/dev/null))
     && !system (qq(LD_LIBRARY_PATH=$build_dir \\
                    g-ir-scanner \\
@@ -133,8 +132,9 @@ sub compile_test_libraries {
     && !system (qq(g-ir-compiler Regress-1.0.gir -o Regress-1.0.typelib \\
                    1>/dev/null 2>/dev/null))
     && !system (qq(gcc -shared -fPIC -g \\
-                   $glib_flags{cflags} $glib_flags{libs} \\
+                   $glib_flags{cflags} \\
                    $testsdir/gimarshallingtests.c \\
+                   $glib_flags{libs} \\
                    -o libgimarshallingtests.so 1>/dev/null 2>/dev/null))
     && !system (qq(LD_LIBRARY_PATH=$build_dir \\
                    g-ir-scanner \\
diff --git a/NEWS b/NEWS
index 76c3dc3..f460578 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,8 @@
+Overview of changes in Glib::Object::Introspection <next>
+========================================================
+
+* Correctly place the linker flags when building the test libs.
+
 Overview of changes in Glib::Object::Introspection 0.009
 ========================================================
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]