[gnome-terminal] server: No need to memdup the FD array
- From: Christian Persch <chpe src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-terminal] server: No need to memdup the FD array
- Date: Thu, 3 May 2012 19:06:52 +0000 (UTC)
commit 3b23f6322e4b7663bebc3ef7fb48a24cad469fff
Author: Christian Persch <chpe gnome org>
Date: Mon Apr 16 13:27:13 2012 +0200
server: No need to memdup the FD array
src/terminal-screen.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/src/terminal-screen.c b/src/terminal-screen.c
index 09050be..2ef315a 100644
--- a/src/terminal-screen.c
+++ b/src/terminal-screen.c
@@ -56,7 +56,7 @@
typedef struct {
GUnixFDList *fd_list;
- int *fd_array;
+ const int *fd_array;
gsize fd_array_len;
} FDSetupData;
@@ -722,12 +722,9 @@ terminal_screen_exec (TerminalScreen *screen,
priv->initial_working_directory = g_strdup (cwd);
if (fd_list) {
- const int *fd_array_data;
-
data = g_new (FDSetupData, 1);
data->fd_list = fd_list;
- fd_array_data = g_variant_get_fixed_array (fd_array, &data->fd_array_len, 2 * sizeof (int));
- data->fd_array = g_memdup (fd_array_data, data->fd_array_len * 2 * sizeof (int));
+ data->fd_array = g_variant_get_fixed_array (fd_array, &data->fd_array_len, 2 * sizeof (int));
} else
data = NULL;
@@ -1377,14 +1374,13 @@ info_bar_response_cb (GtkWidget *info_bar,
static void
free_fd_setup_data (FDSetupData *data)
{
- g_free (data->fd_array);
g_free (data);
}
static void
terminal_screen_child_setup (FDSetupData *data)
{
- int *fd_array = data->fd_array;
+ const int *fd_array = data->fd_array;
gsize fd_array_len = data->fd_array_len;
gsize i;
int *fds, n_fds, j, r;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]