[gtkmm] RGBA: set_grey(), set_grey_u(): Correct the default alpha values.



commit a1f0d0e0000f960d34ed602243cab252d5f82214
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Mar 13 09:31:20 2012 +0100

    RGBA: set_grey(), set_grey_u(): Correct the default alpha values.
    
    * gdk/src/rgba.hg: The default values for these two methods were
    swapped. This could cause some slight change of behaviour in
    existing applications, but the previously wrong values should
    have been obvious, and corrected, in applications already.
    Bug #671573 (Mark Vender)

 ChangeLog       |   10 ++++++++++
 gdk/src/rgba.hg |    8 ++++----
 2 files changed, 14 insertions(+), 4 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 71515cf..4c4310c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2012-03-13  Murray Cumming  <murrayc murrayc com>
+
+	RGBA: set_grey(), set_grey_u(): Correct the default alpha values.
+
+	* gdk/src/rgba.hg: The default values for these two methods were
+	swapped. This could cause some slight change of behaviour in
+	existing applications, but the previously wrong values should
+	have been obvious, and corrected, in applications already.
+	Bug #671573 (Mark Vender)
+
 3.3.18:
 
 2012-03-03  Murray Cumming  <murrayc murrayc com>
diff --git a/gdk/src/rgba.hg b/gdk/src/rgba.hg
index 00a083a..b9d0a5c 100644
--- a/gdk/src/rgba.hg
+++ b/gdk/src/rgba.hg
@@ -53,22 +53,22 @@ public:
   /** Set a grey color, by using the same value for all color components.
    * @param value The value to be used for the red, green, and blue components.
    */
-  void set_grey_u(gushort value, gushort alpha = 1);
-  void set_grey(double g, double alpha = 65535.0);
+  void set_grey_u(gushort value, gushort alpha = 65535);
+  void set_grey(double g, double alpha = 1.0);
 
   /** Set the color, by specifying red, green, and blue color component values.
    * @param red_ The red component of the color.
    * @param green_ The green component of the color.
    * @param blue_ The blue component of the color.
    */
-  void set_rgba_u(gushort red_, gushort green_, gushort blue_, gushort alpha_ = 65535.0);
+  void set_rgba_u(gushort red_, gushort green_, gushort blue_, gushort alpha_ = 65535);
 
   /** Set the color, by specifying red, green, and blue color component values, as percentages.
    * @param red_ The red component of the color, as a percentage.
    * @param green_ The green component of the color, as a percentage.
    * @param blue_ The blue component of the color, as a percentage.
    */
-  void set_rgba(double red_, double green_, double blue_, double alpha_ = 1);
+  void set_rgba(double red_, double green_, double blue_, double alpha_ = 1.0);
 
   //TODO: Add alpha parameter?
   void set_hsv(double h, double s, double v);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]