[gtk+] selector: Remove a misleading error message



commit eb013767bbfd2943ad886d1d61763d8f7faba231
Author: Benjamin Otte <otte redhat com>
Date:   Wed Feb 15 17:18:22 2012 +0100

    selector: Remove a misleading error message
    
    Duplicate selectors are indeed fine and shouldn't cause errors.
    You want to use them to up specificity.

 gtk/gtkcssselector.c              |    8 --------
 tests/css/parser/Makefile.am      |    1 -
 tests/css/parser/selector.errors  |    1 -
 tests/css/parser/selector.ref.css |    8 ++++----
 4 files changed, 4 insertions(+), 14 deletions(-)
---
diff --git a/gtk/gtkcssselector.c b/gtk/gtkcssselector.c
index 71247c0..96f010a 100644
--- a/gtk/gtkcssselector.c
+++ b/gtk/gtkcssselector.c
@@ -187,14 +187,6 @@ parse_selector_pseudo_class (GtkCssParser   *parser,
     {
       if (g_ascii_strcasecmp (name, classes[i].name) == 0)
         {
-          if ((*region_to_modify & classes[i].region_flag) ||
-              (*state_to_modify & classes[i].state_flag))
-            {
-              if (classes == nth_child_classes)
-                _gtk_css_parser_error (parser, "Duplicate pseudo-class 'nth-child(%s)'", name);
-              else
-                _gtk_css_parser_error (parser, "Duplicate pseudo-class '%s'", name);
-            }
           *region_to_modify |= classes[i].region_flag;
           *state_to_modify |= classes[i].state_flag;
 
diff --git a/tests/css/parser/Makefile.am b/tests/css/parser/Makefile.am
index 44bf32a..af82581 100644
--- a/tests/css/parser/Makefile.am
+++ b/tests/css/parser/Makefile.am
@@ -296,7 +296,6 @@ EXTRA_DIST += \
 	pseudo-classes-unknown.errors \
 	pseudo-classes-unknown.ref.css \
 	selector.css \
-	selector.errors \
 	selector.ref.css \
 	shorthand.css \
 	shorthand.ref.css \
diff --git a/tests/css/parser/selector.ref.css b/tests/css/parser/selector.ref.css
index 37ba16a..e982145 100644
--- a/tests/css/parser/selector.ref.css
+++ b/tests/css/parser/selector.ref.css
@@ -86,10 +86,6 @@ a > b {
   int-property: 42;
 }
 
-:hover {
-  int-property: 42;
-}
-
 a.b {
   int-property: 42;
 }
@@ -166,6 +162,10 @@ a > :hover {
   int-property: 42;
 }
 
+:hover:hover {
+  int-property: 42;
+}
+
 :hover :hover {
   int-property: 42;
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]