[gtk+/gtk-3-4] Bug 676077: Fix handling of Keyboard Input on Windows
- From: Chun-wei Fan <fanchunwei src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/gtk-3-4] Bug 676077: Fix handling of Keyboard Input on Windows
- Date: Mon, 25 Jun 2012 15:25:24 +0000 (UTC)
commit 2c01d52a7e8cd7387bbfc68679958f9945944e2b
Author: Chun-wei Fan <fanchunwei src gnome org>
Date: Tue May 15 16:16:25 2012 +0800
Bug 676077: Fix handling of Keyboard Input on Windows
Don't use ASCII control characters to denote the input of Esc, Tab,
Return/Enter, Backspace and Delete, as it seems that it is not how
Windows handle them, and they cause weird characters to appear in the
input field on GTK+3 programs in non-English Windows. Instead, let
these keys be handled as-is on Windows, like what is done in GTK+-2.x.
Checked with mclasen on IRC, and thanks to the people who verified the
patch to not break anything on English Windows.
gdk/gdkkeyuni.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/gdk/gdkkeyuni.c b/gdk/gdkkeyuni.c
index 3a7cca1..c951ad8 100644
--- a/gdk/gdkkeyuni.c
+++ b/gdk/gdkkeyuni.c
@@ -830,13 +830,18 @@ static const struct {
/* Following items added to GTK, not in the xterm table */
/* A few ASCII control characters */
-
+#ifndef GDK_WINDOWING_WIN32
{ 0xFF08 /* Backspace */, '\b' },
{ 0xFF09 /* Tab */, '\t' },
+#endif
+
{ 0xFF0A /* Linefeed */, '\n' },
{ 0xFF0B /* Vert. Tab */, '\v' },
+
+#ifndef GDK_WINDOWING_WIN32
{ 0xFF0D /* Return */, '\r' },
{ 0xFF1B /* Escape */, '\033' },
+#endif
/* Numeric keypad */
@@ -861,7 +866,9 @@ static const struct {
/* End numeric keypad */
+#ifndef GDK_WINDOWING_WIN32
{ 0xFFFF /* Delete */, '\177' }
+#endif
};
/**
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]