[glibmm/gmmproc-refactor] Implicitly overwrite specific conversions.



commit ad6056f7dd49b866a96c6099c96e2b9f39fafed7
Author: Krzesimir Nowak <qdlacz gmail com>
Date:   Thu Jun 14 04:22:42 2012 +0200

    Implicitly overwrite specific conversions.

 tools/pm/Common/TypeInfo/Common.pm |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/tools/pm/Common/TypeInfo/Common.pm b/tools/pm/Common/TypeInfo/Common.pm
index efa8567..50fd5c4 100644
--- a/tools/pm/Common/TypeInfo/Common.pm
+++ b/tools/pm/Common/TypeInfo/Common.pm
@@ -97,11 +97,8 @@ sub add_specific_conversion ($$$$$$)
 
   my $from_conversions = $conversions->{$from};
 
-  unless (exists $from_conversions->{$to})
-  {
-    $from_conversions->{$to} = [$transfer_none, $transfer_container, $transfer_full];
-  }
-# TODO: what should be done with duplicates?
+# TODO: should we warn about overwriting previous conversion if it existed?
+  $from_conversions->{$to} = [$transfer_none, $transfer_container, $transfer_full];
 }
 
 sub get_specific_conversion ($$$$$)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]