[evolution-data-server] Bug 678618 - Runtime warning when clicking on top-level sidebar item



commit ef13d4256456f9f0968f955376ec9c54cb428faa
Author: Matthew Barnes <mbarnes redhat com>
Date:   Fri Jun 22 08:19:58 2012 -0400

    Bug 678618 - Runtime warning when clicking on top-level sidebar item

 libedataserverui/e-source-selector.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/libedataserverui/e-source-selector.c b/libedataserverui/e-source-selector.c
index 5ef4084..fd24086 100644
--- a/libedataserverui/e-source-selector.c
+++ b/libedataserverui/e-source-selector.c
@@ -1954,7 +1954,11 @@ e_source_selector_set_primary_selection (ESourceSelector *selector,
 		return;
 
 	extension_name = e_source_selector_get_extension_name (selector);
-	g_return_if_fail (e_source_has_extension (source, extension_name));
+
+	/* Return silently if attempting to select a parent node
+	 * lacking the expected extension (e.g. On This Computer). */
+	if (!e_source_has_extension (source, extension_name))
+		return;
 
 	/* We block the signal because this all needs to be atomic */
 	g_signal_handlers_block_matched (



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]