[glib/glib-2-32] msvc_recommended_pragmas.h: Re-enable C4819 warnings



commit fd8d17726f8a16f50b6afe6e6bb58958daf64c1b
Author: Chun-wei Fan <fanchunwei src gnome org>
Date:   Wed Jun 20 10:19:14 2012 +0800

    msvc_recommended_pragmas.h: Re-enable C4819 warnings
    
    Apparently the C4819 warnings appear due to a bug on Visual C++ on DBCS
    locales, so re-enable this.
    
    Add a note in the Visual C++ Readme.txt's regarding this.

 build/win32/vs10/README.txt |    7 +++++++
 build/win32/vs9/README.txt  |    7 +++++++
 msvc_recommended_pragmas.h  |    3 ---
 3 files changed, 14 insertions(+), 3 deletions(-)
---
diff --git a/build/win32/vs10/README.txt b/build/win32/vs10/README.txt
index 69da5f4..b5e092f 100644
--- a/build/win32/vs10/README.txt
+++ b/build/win32/vs10/README.txt
@@ -73,5 +73,12 @@ built DLLs go into <root>\vs10\<PlatformName>\bin, built LIBs into
 project files higher in the stack are supposed to look for them, not
 from a specific GLib source tree.
 
+Note: If you see C4819 warnings and you are compiling GLib on a DBCS
+(Chinese/Korean/Japanese) version of Windows, you may need to switch
+to an English locale in Control Panel->Region and Languages->System->
+Change System Locale, reboot and rebuild to ensure GLib, Pango, GDK-Pixbuf,
+ATK and GTK+ is built correctly.  This is due to a bug in Visual C++ running
+on DBCS locales.
+
 --Tor Lillqvist <tml iki fi>
 --Updated by Chun-wei Fan <fanc999 gmail com>
diff --git a/build/win32/vs9/README.txt b/build/win32/vs9/README.txt
index d760ce8..59e77b2 100644
--- a/build/win32/vs9/README.txt
+++ b/build/win32/vs9/README.txt
@@ -73,5 +73,12 @@ built DLLs go into <root>\vs9\<PlatformName>\bin, built LIBs into
 project files higher in the stack are supposed to look for them, not
 from a specific GLib source tree.
 
+Note: If you see C4819 warnings and you are compiling GLib on a DBCS
+(Chinese/Korean/Japanese) version of Windows, you may need to switch
+to an English locale in Control Panel->Region and Languages->System->
+Change System Locale, reboot and rebuild to ensure GLib, Pango, GDK-Pixbuf,
+ATK and GTK+ is built correctly.  This is due to a bug in Visual C++ running
+on DBCS locales.
+
 --Tor Lillqvist <tml iki fi>
 --Updated by Chun-wei Fan <fanc999 gmail com>
diff --git a/msvc_recommended_pragmas.h b/msvc_recommended_pragmas.h
index ff4028e..f78f9a1 100644
--- a/msvc_recommended_pragmas.h
+++ b/msvc_recommended_pragmas.h
@@ -27,9 +27,6 @@
 #pragma warning(disable:4244)	/* No possible loss of data warnings */
 #pragma warning(disable:4305)   /* No truncation from int to char warnings */
 
-/* The file contains a character that cannot be represented in the current code page */
-#pragma warning(disable:4819)
-
 /* work around Microsoft's premature attempt to deprecate the C-Library */
 #define _CRT_SECURE_NO_WARNINGS
 #define _CRT_NONSTDC_NO_WARNINGS



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]