[gtk+/gtk-3-4] iconview: Don't shrink items
- From: Benjamin Otte <otte src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/gtk-3-4] iconview: Don't shrink items
- Date: Tue, 19 Jun 2012 12:29:31 +0000 (UTC)
commit eb74c6f7d094023ef88564d75cea35c07f66e4c2
Author: Benjamin Otte <otte redhat com>
Date: Sun Jun 10 16:28:47 2012 +0200
iconview: Don't shrink items
The previous code assumed that the width was always enough for more than
one column, which is obviously not correct when a number of columns is
hardcoded.
With this patch, it will now always check that the width is enough and
otherwise cause scrolling.
https://bugzilla.gnome.org/show_bug.cgi?id=677809
gtk/gtkiconview.c | 13 +++----------
1 files changed, 3 insertions(+), 10 deletions(-)
---
diff --git a/gtk/gtkiconview.c b/gtk/gtkiconview.c
index ca05842..a451735 100644
--- a/gtk/gtkiconview.c
+++ b/gtk/gtkiconview.c
@@ -2868,16 +2868,9 @@ gtk_icon_view_layout (GtkIconView *icon_view)
&n_columns, &item_width);
n_rows = (n_items + n_columns - 1) / n_columns;
- if (n_columns <= 1)
- {
- /* We might need vertical scrolling here */
- int min_width = item_width + 2 * priv->item_padding + 2 * priv->margin;
- priv->width = MAX (min_width, gtk_widget_get_allocated_width (widget));
- }
- else
- {
- priv->width = gtk_widget_get_allocated_width (widget);
- }
+ priv->width = n_columns * (item_width + 2 * priv->item_padding + priv->column_spacing) - priv->column_spacing;
+ priv->width += 2 * priv->margin;
+ priv->width = MAX (priv->width, gtk_widget_get_allocated_width (widget));
/* Clear the per row contexts */
g_ptr_array_set_size (icon_view->priv->row_contexts, 0);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]