[gnome-boxes] Disable Spice display resize-guest when minimizing
- From: Marc-Andre Lureau <malureau src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes] Disable Spice display resize-guest when minimizing
- Date: Sun, 17 Jun 2012 23:05:17 +0000 (UTC)
commit e6e1f7720a7fd1d20e02842fd10484f795b004e2
Author: Marc-Andrà Lureau <marcandre lureau gmail com>
Date: Fri Jun 8 23:28:19 2012 +0200
Disable Spice display resize-guest when minimizing
With recent QXL driver, the guest get resized to arbitrary resolution,
which ends up in useless and very low resolution when switching to
properties view. Stop resizing the display when switching to properties.
https://bugzilla.gnome.org/show_bug.cgi?id=677730
src/spice-display.vala | 41 ++++++++++++++++++++++++++---------------
1 files changed, 26 insertions(+), 15 deletions(-)
---
diff --git a/src/spice-display.vala b/src/spice-display.vala
index 87a70bd..05fb679 100644
--- a/src/spice-display.vala
+++ b/src/spice-display.vala
@@ -6,14 +6,29 @@ private class Boxes.SpiceDisplay: Boxes.Display, Boxes.IPropertiesProvider {
public override string protocol { get { return "SPICE"; } }
public override string uri { owned get { return session.uri; } }
- private Session session;
- private unowned GtkSession gtk_session;
- private unowned Audio audio;
+ private Spice.Session session;
+ private unowned Spice.GtkSession gtk_session;
+ private unowned Spice.Audio audio;
private ulong channel_new_id;
private ulong channel_destroy_id;
private Display.SavedProperty[] display_saved_properties;
private Display.SavedProperty[] gtk_session_saved_properties;
+ public bool resize_guest { get; set; }
+ private void ui_state_changed () {
+ // TODO: multi display
+ try {
+ var display = get_display (0) as Spice.Display;
+ if (App.app.ui_state == UIState.PROPERTIES) {
+ // disable resize guest when minimizing guest widget
+ display.resize_guest = false;
+ } else if (App.app.ui_state == UIState.DISPLAY) {
+ display.resize_guest = resize_guest;
+ }
+ } catch (Boxes.Error error) {
+ }
+ }
+
construct {
display_saved_properties = {
SavedProperty () { name = "resize-guest", default_value = true }
@@ -32,6 +47,8 @@ private class Boxes.SpiceDisplay: Boxes.Display, Boxes.IPropertiesProvider {
this.notify["config"].connect (() => {
sync_config_with_display (gtk_session, gtk_session_saved_properties);
});
+
+ App.app.notify["ui-state"].connect (ui_state_changed);
}
public SpiceDisplay (DisplayConfig config, string host, int port) {
@@ -59,8 +76,7 @@ private class Boxes.SpiceDisplay: Boxes.Display, Boxes.IPropertiesProvider {
display.mouse_grab.connect((status) => {
mouse_grabbed = status != 0;
});
- sync_config_with_display (display, display_saved_properties);
-
+ sync_config_with_display (this, display_saved_properties);
display.scaling = true;
displays.replace (n, display);
@@ -141,16 +157,11 @@ private class Boxes.SpiceDisplay: Boxes.Display, Boxes.IPropertiesProvider {
toggle.halign = Gtk.Align.START;
add_property (ref list, _("Share clipboard"), toggle);
- try {
- toggle = new Gtk.Switch ();
- var display = get_display (0);
- display.bind_property ("resize-guest", toggle, "active",
- BindingFlags.BIDIRECTIONAL | BindingFlags.SYNC_CREATE);
- toggle.halign = Gtk.Align.START;
- add_property (ref list, _("Resize guest"), toggle);
- } catch (Boxes.Error error) {
- warning (error.message);
- }
+ toggle = new Gtk.Switch ();
+ this.bind_property ("resize-guest", toggle, "active",
+ BindingFlags.BIDIRECTIONAL | BindingFlags.SYNC_CREATE);
+ toggle.halign = Gtk.Align.START;
+ add_property (ref list, _("Resize guest"), toggle);
break;
case PropertiesPage.DEVICES:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]