[pitivi] dogtail tests: Make the importing helper functions more robust

[Jean-FranÃois Fortin Tam <jfft src gnome org>]

commit 91960d3534108e4fb9918591ba29dddcc974923e
Author: Jean-FranÃois Fortin Tam <nekohayo gmail com>
Date:   Tue Jul 24 14:49:19 2012 -0400

    dogtail tests: Make the importing helper functions more robust
    
    Handle cases where icons for imported clips are not shown due
    to media library search results filtering.

 tests/dogtail_scripts/helper_functions.py |   26 ++++++++++++++++++++------
 1 files changed, 20 insertions(+), 6 deletions(-)
---
diff --git a/tests/dogtail_scripts/helper_functions.py b/tests/dogtail_scripts/helper_functions.py
index 7b57961..96f9025 100644
--- a/tests/dogtail_scripts/helper_functions.py
+++ b/tests/dogtail_scripts/helper_functions.py
@@ -92,18 +92,21 @@ class HelpFunc(BaseDogTail):
         dogtail.rawinput.pressKey("Enter")  # Don't search for the Add button
         sleep(0.6)
 
+        # Check if the item is now visible in the media library.
         libtab = self.pitivi.tab("Media Library")
         for i in range(5):
+            # The time it takes for the icon to appear is unpredictable,
+            # therefore we try up to 5 times to look for it
             icons = libtab.findChildren(GenericPredicate(roleName="icon"))
-            sample = None
             for icon in icons:
                 if icon.text == filename:
-                    sample = icon
-            if sample is not None:
-                break
+                    return icon
             sleep(0.5)
-        self.assertIsNotNone(sample)
-        return sample
+        # Failure to find an icon might be because it is hidden due to a search
+        current_search_text = libtab.child(roleName="text").text.lower()
+        self.assertNotEqual(current_search_text, "")
+        self.assertNotIn(filename.lower(), current_search_text)
+        return None
 
     def import_media_multiple(self, files):
         dogtail.rawinput.pressKey("Esc")  # Ensure the welcome dialog is closed
@@ -129,9 +132,20 @@ class HelpFunc(BaseDogTail):
             import_dialog.child(name=f).click()
         registry.generateKeyboardEvent(code, None, KEY_RELEASE)
         import_dialog.button('Add').click()
+
         libtab = self.pitivi.tab("Media Library")
+        current_search_text = libtab.child(roleName="text").text.lower()
+        if current_search_text != "":
+            # Failure to find some icons might be because of search filtering.
+            # The following avoids searching for files that can't be found.
+            for f in files:
+                if current_search_text not in f.lower():
+                    files.remove(f)
+        # Check if non-filtered items are now visible in the media library.
         samples = []
         for i in range(5):
+            # The time it takes for icons to appear is unpredictable,
+            # therefore we try up to 5 times to look for them
             icons = libtab.findChildren(GenericPredicate(roleName="icon"))
             for icon in icons:
                 for f in files: