[gnumeric] Dependents: fix cleanup problem.



commit b29f0d4f27cae04353a5396bf30fe2a084b3cebe
Author: Morten Welinder <terra gnome org>
Date:   Tue Jul 24 14:59:09 2012 -0400

    Dependents: fix cleanup problem.
    
    One difference between the link and unlink paths was missed.

 ChangeLog       |    5 +++++
 src/dependent.c |    5 ++++-
 2 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index f66aa7c..b27ee26 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-07-24  Morten Welinder  <terra gnome org>
+
+	* src/dependent.c (link_unlink_expr_dep): Fix problem from
+	earlier cleanup.
+
 2012-07-22  Morten Welinder  <terra gnome org>
 
 	* src/dependent.c (dependent_eval): Do the same thing for all
diff --git a/src/dependent.c b/src/dependent.c
index d86646f..577d739 100644
--- a/src/dependent.c
+++ b/src/dependent.c
@@ -1075,7 +1075,10 @@ link_unlink_expr_dep (GnmEvalPos *ep, GnmExpr const *tree, gboolean qlink)
 	}
 
 	case GNM_EXPR_OP_NAME:
-		expr_name_add_dep (tree->name.name, ep->dep);
+		if (qlink)
+			expr_name_add_dep (tree->name.name, ep->dep);
+		else
+			expr_name_remove_dep (tree->name.name, ep->dep);
 		if (expr_name_is_active (tree->name.name))
 			return link_unlink_expr_dep (ep, tree->name.name->texpr->expr, qlink) | DEPENDENT_USES_NAME;
 		return DEPENDENT_USES_NAME;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]