[gdm] daemon: Fix error handling in BeginVerification and siblings



commit 48d2e54c4d0b1f665b81336a1232ed3891a9843d
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Thu Jul 19 16:21:42 2012 -0400

    daemon: Fix error handling in BeginVerification and siblings
    
    We were trying to return an error on the wrong invocation.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=678057

 daemon/gdm-session.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/daemon/gdm-session.c b/daemon/gdm-session.c
index 4a03add..1cf4f28 100644
--- a/daemon/gdm-session.c
+++ b/daemon/gdm-session.c
@@ -1363,7 +1363,7 @@ gdm_session_handle_client_begin_verification (GdmDBusUserVerifier    *user_verif
                 conversation->starting_invocation = g_object_ref (invocation);
                 conversation->starting_username = NULL;
         } else {
-                g_dbus_method_invocation_return_error (conversation->starting_invocation,
+                g_dbus_method_invocation_return_error (invocation,
                                                        G_DBUS_ERROR,
                                                        G_DBUS_ERROR_SPAWN_FAILED,
                                                        _("Could not create authentication helper process"));
@@ -1389,7 +1389,7 @@ gdm_session_handle_client_begin_verification_for_user (GdmDBusUserVerifier    *u
                 conversation->starting_invocation = g_object_ref (invocation);
                 conversation->starting_username = g_strdup (username);
         } else {
-                g_dbus_method_invocation_return_error (conversation->starting_invocation,
+                g_dbus_method_invocation_return_error (invocation,
                                                        G_DBUS_ERROR,
                                                        G_DBUS_ERROR_SPAWN_FAILED,
                                                        _("Could not create authentication helper process"));



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]