=?utf-8?q?=5Bfolks=5D_core=3A_Don=E2=80=99t_keep_references_to_PersonaSto?= =?utf-8?q?res_in_each_Individual?=



commit 6f743fdc074910ff8f4d0b91753e82a0b2c92867
Author: Philip Withnall <philip tecnocode co uk>
Date:   Fri Jun 22 19:03:55 2012 +0100

    core: Donât keep references to PersonaStores in each Individual
    
    Pointless and it makes debugging reference counting bugs a real pain.

 folks/individual.vala |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/folks/individual.vala b/folks/individual.vala
index 06bcc32..881bfc1 100644
--- a/folks/individual.vala
+++ b/folks/individual.vala
@@ -108,8 +108,8 @@ public class Folks.Individual : Object,
   /* Mapping from PersonaStore -> number of Personas from that store contained
    * in this Individual. There shouldn't be any entries with a number < 1.
    * This is used for working out when to disconnect from store signals. */
-  private HashMap<PersonaStore, uint> _stores =
-      new HashMap<PersonaStore, uint> (null, null);
+  private HashMap<unowned PersonaStore, uint> _stores =
+      new HashMap<unowned PersonaStore, uint> (null, null);
   /* The number of Personas in this Individual which have
    * Persona.is_user == true. Iff this is > 0, Individual.is_user == true. */
   private uint _persona_user_count = 0;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]