[balsa/gtk3] Plug memory leaks
- From: Peter Bloomfield <PeterB src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [balsa/gtk3] Plug memory leaks
- Date: Mon, 16 Jul 2012 01:51:20 +0000 (UTC)
commit 64050a8efd25dee418a0dc421e4078211bb02f40
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date: Sun Jul 15 19:34:14 2012 -0400
Plug memory leaks
* libbalsa/address-book-ldap.c
(libbalsa_address_book_ldap_get_address): drop useless
assignment to nick_name, fix mem leak;
(libbalsa_address_book_ldap_modify_address): fix mem leak.
ChangeLog | 7 +++++++
libbalsa/address-book-ldap.c | 12 +++++++-----
2 files changed, 14 insertions(+), 5 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index fb25ddf..70b7afa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2012-07-15 Peter Bloomfield
+ * libbalsa/address-book-ldap.c
+ (libbalsa_address_book_ldap_get_address): drop useless
+ assignment to nick_name, fix mem leak;
+ (libbalsa_address_book_ldap_modify_address): fix mem leak.
+
+2012-07-15 Peter Bloomfield
+
* libbalsa/address-book-extern.c (parse_externq_file): pipe
stream must be closed with pclose, not fclose.
diff --git a/libbalsa/address-book-ldap.c b/libbalsa/address-book-ldap.c
index 4b44e84..463749e 100644
--- a/libbalsa/address-book-ldap.c
+++ b/libbalsa/address-book-ldap.c
@@ -492,9 +492,8 @@ libbalsa_address_book_ldap_get_address(LibBalsaAddressBook * ab,
g_return_val_if_fail(email != NULL, NULL);
address = libbalsa_address_new();
- address->nick_name = cn ? cn : g_strdup(_("No-Id"));
- if (cn)
- address->full_name = g_strdup(cn);
+ if (cn)
+ address->full_name = cn;
else {
address->full_name = create_name(first, last);
if(!address->full_name)
@@ -798,8 +797,11 @@ libbalsa_address_book_ldap_modify_address(LibBalsaAddressBook *ab,
}
mods[cnt] = NULL;
- if(cnt == 0) /* nothing to modify */
- return LBABERR_OK;
+ if(cnt == 0) {
+ /* nothing to modify */
+ g_free(dn);
+ return LBABERR_OK;
+ }
cnt = 0;
do {
rc = ldap_modify_ext_s(ldap_ab->directory, dn, mods, NULL, NULL);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]