[latexila] Remove the setting of the latexmk post-processor

[SÃbastien Wilmet <swilmet src gnome org>]

commit 1b5068209015b3b6f9f2ab4bf52096ec3e35b9e6
Author: SÃbastien Wilmet <swilmet src gnome org>
Date:   Sat Jul 14 00:20:16 2012 +0200

    Remove the setting of the latexmk post-processor

 data/org.gnome.latexila.gschema.xml |    9 ---------
 src/build_job_runner.vala           |    7 +------
 src/post_processors.vala            |    6 ++----
 src/preferences_dialog.vala         |    6 +-----
 src/ui/preferences_dialog.ui        |   19 -------------------
 5 files changed, 4 insertions(+), 43 deletions(-)
---
diff --git a/data/org.gnome.latexila.gschema.xml b/data/org.gnome.latexila.gschema.xml
index 183d7cf..f42860c 100644
--- a/data/org.gnome.latexila.gschema.xml
+++ b/data/org.gnome.latexila.gschema.xml
@@ -133,15 +133,6 @@
       <summary>Interactive completion min chars</summary>
       <description>Minimum number of characters after '\' for interactive completion</description>
     </key>
-    <key name="latexmk-always-show-all" type="b">
-      <default>false</default>
-      <summary>Latexmk always show all</summary>
-      <description>
-        Always show all information for the Latexmk post processor.
-        If it is set to false, all the information will be displayed only if
-        an error occurs during a command other than 'latex' or 'pdflatex'.
-      </description>
-    </key>
     <key name="no-confirm-clean" type="b">
       <default>false</default>
       <summary>No confirmation clean-up</summary>
diff --git a/src/build_job_runner.vala b/src/build_job_runner.vala
index 9382891..b698af6 100644
--- a/src/build_job_runner.vala
+++ b/src/build_job_runner.vala
@@ -159,12 +159,7 @@ public class BuildJobRunner : GLib.Object
                 break;
 
             case PostProcessorType.LATEXMK:
-                GLib.Settings settings =
-                    new GLib.Settings ("org.gnome.latexila.preferences.latex");
-
-                bool show_all = settings.get_boolean ("latexmk-always-show-all");
-
-                _post_processor = new LatexmkPostProcessor (exit_status, show_all);
+                _post_processor = new LatexmkPostProcessor (exit_status);
                 break;
 
             case PostProcessorType.NO_OUTPUT:
diff --git a/src/post_processors.vala b/src/post_processors.vala
index b66bdf7..2c95f6f 100644
--- a/src/post_processors.vala
+++ b/src/post_processors.vala
@@ -162,12 +162,10 @@ private class LatexmkPostProcessor : PostProcessor
     private static Regex? _reg_rule = null;
     private static Regex? _reg_no_rule = null;
     private int _exit_status;
-    private bool _force_show_all;
 
-    public LatexmkPostProcessor (int exit_status, bool force_show_all)
+    public LatexmkPostProcessor (int exit_status)
     {
         _exit_status = exit_status;
-        _force_show_all = force_show_all;
 
         if (_reg_rule != null)
             return;
@@ -290,7 +288,7 @@ private class LatexmkPostProcessor : PostProcessor
             // Almost all the time, the user wants to see only the latex output.
             // If an error has occured, we verify if the last command was a latex command.
             // If it is the case, there is no need to show all output.
-            if (! _force_show_all && (_exit_status == 0 || last_cmd_is_latex_cmd))
+            if (_exit_status == 0 || last_cmd_is_latex_cmd)
                 _all_messages = (owned) latex_messages;
 
             // Replace 'last_latex_node' by 'latex_messages'
diff --git a/src/preferences_dialog.vala b/src/preferences_dialog.vala
index e096e98..61f62cc 100644
--- a/src/preferences_dialog.vala
+++ b/src/preferences_dialog.vala
@@ -291,14 +291,10 @@ public class PreferencesDialog : Dialog
         set_plural (interactive_comp_label, settings, "interactive-completion-num",
             (n) => ngettext ("character", "characters", n));
 
-        var latexmk_checkbutton = builder.get_object ("latexmk_checkbutton");
-        settings.bind ("latexmk-always-show-all", latexmk_checkbutton, "active",
-            SettingsBindFlags.DEFAULT);
-
         Grid grid_latex_tab = builder.get_object ("grid_latex_tab") as Grid;
         Grid build_tools_preferences = new BuildToolsPreferences ();
         build_tools_preferences.set_margin_left (12);
-        grid_latex_tab.attach (build_tools_preferences, 0, 3, 1, 1);
+        grid_latex_tab.attach (build_tools_preferences, 0, 2, 1, 1);
     }
 
     private void init_other_tab (Builder builder)
diff --git a/src/ui/preferences_dialog.ui b/src/ui/preferences_dialog.ui
index 5378a08..8fe0bc4 100644
--- a/src/ui/preferences_dialog.ui
+++ b/src/ui/preferences_dialog.ui
@@ -524,25 +524,6 @@
                 <property name="height">1</property>
               </packing>
             </child>
-            <child>
-              <object class="GtkCheckButton" id="latexmk_checkbutton">
-                <property name="label" translatable="yes">Always show all information for the Latexmk post processor</property>
-                <property name="use_action_appearance">False</property>
-                <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="receives_default">False</property>
-                <property name="margin_left">12</property>
-                <property name="use_action_appearance">False</property>
-                <property name="xalign">0</property>
-                <property name="draw_indicator">True</property>
-              </object>
-              <packing>
-                <property name="left_attach">0</property>
-                <property name="top_attach">2</property>
-                <property name="width">1</property>
-                <property name="height">1</property>
-              </packing>
-            </child>
           </object>
           <packing>
             <property name="position">2</property>