[moserial] Fix -Werror=format-security errors.
- From: Michael J. Chudobiak <mjc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [moserial] Fix -Werror=format-security errors.
- Date: Wed, 11 Jul 2012 17:26:02 +0000 (UTC)
commit 9b998d565a1c773e766668b9d5d54644f7c2fc10
Author: Rodolphe Pelloux-Prayer <rodolphe damsy net>
Date: Wed Jul 4 13:32:30 2012 +0200
Fix -Werror=format-security errors.
src/MainWindow.vala | 8 ++++----
src/Profile.vala | 4 ++--
src/Rzwrapper.vala | 2 +-
src/Szwrapper.vala | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/src/MainWindow.vala b/src/MainWindow.vala
index 2df511f..f597a40 100644
--- a/src/MainWindow.vala
+++ b/src/MainWindow.vala
@@ -427,7 +427,7 @@ public class moserial.MainWindow : Gtk.Window //Have to extend Gtk.Winow to get
}
}
catch (HexParseError e) {
- var errorDialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, e.message);
+ var errorDialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s", e.message);
errorDialog.run();
errorDialog.destroy();
}
@@ -559,7 +559,7 @@ public class moserial.MainWindow : Gtk.Window //Have to extend Gtk.Winow to get
stopRecording(dialog);
setWindowTitle(filename);
} catch (GLib.Error e) {
- var errorDialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s\n%s".printf(_("Error: Could not open file"), filename, e.message));
+ var errorDialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s\n%s", _("Error: Could not open file"), filename, e.message);
errorDialog.run();
errorDialog.destroy();
stopRecording(dialog);
@@ -637,7 +637,7 @@ public class moserial.MainWindow : Gtk.Window //Have to extend Gtk.Winow to get
private bool startConnection() {
if (!(serialConnection.doConnect(currentSettings))) {
connectButton.set_active(false);
- var dialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s".printf(_("Error: Could not open device"), currentSettings.device));
+ var dialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s", _("Error: Could not open device"), currentSettings.device);
dialog.run();
dialog.destroy();
return false;
@@ -823,7 +823,7 @@ public class moserial.MainWindow : Gtk.Window //Have to extend Gtk.Winow to get
currentPaths.saveToProfile(profile);
if (profileFilename != null) {
if (profileChanged) {
- var dialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.QUESTION, ButtonsType.YES_NO, _("You have changed your setting or preferences. Do you want to save these changes to the loaded profile?"));
+ var dialog = new MessageDialog (gtkWindow, DialogFlags.DESTROY_WITH_PARENT, MessageType.QUESTION, ButtonsType.YES_NO, "%s", _("You have changed your setting or preferences. Do you want to save these changes to the loaded profile?"));
int response = dialog.run();
if(response == Gtk.ResponseType.YES)
saveProfile();
diff --git a/src/Profile.vala b/src/Profile.vala
index ef4f3f3..cba3024 100644
--- a/src/Profile.vala
+++ b/src/Profile.vala
@@ -73,7 +73,7 @@ public class Profile : GLib.Object
return true;
} catch (GLib.FileError e) {
if (!default_profile) {
- var errorDialog = new MessageDialog (window, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s\n%s".printf(_("Error: Could not open file"), filename, e.message));
+ var errorDialog = new MessageDialog (window, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s\n%s", _("Error: Could not open file"), filename, e.message);
errorDialog.run();
errorDialog.destroy();
}
@@ -104,7 +104,7 @@ public class Profile : GLib.Object
} catch (GLib.Error e) {
stdout.printf("profile.save error: %s\n", e.message);
if (!default_profile) {
- var errorDialog = new MessageDialog (window, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s\n%s".printf(_("Error: Could not open file"), filename, e.message));
+ var errorDialog = new MessageDialog (window, DialogFlags.DESTROY_WITH_PARENT, MessageType.ERROR, ButtonsType.CLOSE, "%s: %s\n%s", _("Error: Could not open file"), filename, e.message);
errorDialog.run();
errorDialog.destroy();
}
diff --git a/src/Rzwrapper.vala b/src/Rzwrapper.vala
index 60809a3..d98b4ea 100644
--- a/src/Rzwrapper.vala
+++ b/src/Rzwrapper.vala
@@ -99,7 +99,7 @@ public class moserial.Rzwrapper: GLib.Object
{
running=false;
stdout.printf("spawn error: %s\n", e.message);
- var errorDialog = new Gtk.MessageDialog (null, Gtk.DialogFlags.DESTROY_WITH_PARENT, Gtk.MessageType.ERROR, Gtk.ButtonsType.CLOSE, "%s".printf(e.message));
+ var errorDialog = new Gtk.MessageDialog (null, Gtk.DialogFlags.DESTROY_WITH_PARENT, Gtk.MessageType.ERROR, Gtk.ButtonsType.CLOSE, "%s", e.message);
errorDialog.run();
errorDialog.destroy();
}
diff --git a/src/Szwrapper.vala b/src/Szwrapper.vala
index 54c52e6..4b932bb 100644
--- a/src/Szwrapper.vala
+++ b/src/Szwrapper.vala
@@ -105,7 +105,7 @@ public class moserial.Szwrapper: GLib.Object
{
running=false;
stdout.printf("spawn error: %s\n", e.message);
- var errorDialog = new Gtk.MessageDialog (null, Gtk.DialogFlags.DESTROY_WITH_PARENT, Gtk.MessageType.ERROR, Gtk.ButtonsType.CLOSE, "%s".printf(e.message));
+ var errorDialog = new Gtk.MessageDialog (null, Gtk.DialogFlags.DESTROY_WITH_PARENT, Gtk.MessageType.ERROR, Gtk.ButtonsType.CLOSE, "%s", e.message);
errorDialog.run();
errorDialog.destroy();
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]