GNOME.org
 

[evolution-ews] Add "Connection timeout" option into mail account properties

commit c8a36fd302c604eceef234ee36e3b283eb206ffe
Author: Milan Crha <mcrha redhat com>
Date:   Wed Jul 11 12:18:37 2012 +0200

    Add "Connection timeout" option into mail account properties
    
    The default libsoup timeout is 0, which means no timeout at all.
    This presets connection timeout to 2 minutes, while users can still
    change this to their will, even back to 0.

 .../exchange-ews-account-out-of-office.c           |    2 +-
 .../exchange-ews-account-setup.c                   |    2 +-
 src/addressbook/e-book-backend-ews.c               |   17 ++++++-
 src/calendar/e-cal-backend-ews.c                   |    4 +-
 src/camel/camel-ews-provider.c                     |    6 +++
 src/camel/camel-ews-store.c                        |   17 +++++++
 src/collection/e-ews-backend.c                     |    4 +-
 .../e-mail-config-ews-oal-combo-box.c              |    4 +-
 src/server/camel-ews-settings.c                    |   48 ++++++++++++++++++++
 src/server/camel-ews-settings.h                    |    4 +-
 src/server/e-ews-connection.c                      |   26 +++++++++-
 src/server/e-ews-connection.h                      |    4 +-
 src/server/tests/test-autocompletion.c             |    2 +-
 src/server/tests/test-connection.c                 |    2 +-
 src/server/tests/test-createfolder.c               |    2 +-
 src/server/tests/test-cuditem.c                    |    2 +-
 src/server/tests/test-deletefolder.c               |    2 +-
 src/server/tests/test-get-oof-settings.c           |    2 +-
 src/server/tests/test-getattachment.c              |    2 +-
 src/server/tests/test-getdelegate.c                |    2 +-
 src/server/tests/test-set-oof-settings.c           |    2 +-
 src/server/tests/test-syncfolder.c                 |    6 +-
 src/utils/ews-test-finditem-query.c                |    2 +-
 23 files changed, 138 insertions(+), 26 deletions(-)
---
diff --git a/src/account-setup-eplugin/exchange-ews-account-out-of-office.c b/src/account-setup-eplugin/exchange-ews-account-out-of-office.c
index 7a34737..690ecdf 100644
--- a/src/account-setup-eplugin/exchange-ews-account-out-of-office.c
+++ b/src/account-setup-eplugin/exchange-ews-account-out-of-office.c
@@ -288,7 +288,7 @@ get_connection (EMConfigTargetSettings *target)
 	password = get_password (target->storage_settings);
 	email = target->email_address;
 
-	cnc = e_ews_connection_new (host_url, user, password, NULL, NULL, &error);
+	cnc = e_ews_connection_new (host_url, user, password, 30, NULL, NULL, &error);
 
 	if (!cnc) {
 		g_warning ("Error in connection: %s\n", error->message);
diff --git a/src/account-setup-eplugin/exchange-ews-account-setup.c b/src/account-setup-eplugin/exchange-ews-account-setup.c
index ba5e6ac..95bdae2 100644
--- a/src/account-setup-eplugin/exchange-ews-account-setup.c
+++ b/src/account-setup-eplugin/exchange-ews-account-setup.c
@@ -276,7 +276,7 @@ fetch_button_clicked_cb (GtkButton *button,
 	password = get_password (target);
 
 	/* pass user name while creating connection  to fetch oals */
-	cnc = e_ews_connection_new (oab_url, user, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (oab_url, user, password, 30, NULL, NULL, NULL);
 	cbdata->cancellable = cancellable;
 	e_ews_connection_get_oal_list (
 		cnc, cancellable, ews_oal_list_ready, cbdata);
diff --git a/src/addressbook/e-book-backend-ews.c b/src/addressbook/e-book-backend-ews.c
index 251b749..e6e59b1 100644
--- a/src/addressbook/e-book-backend-ews.c
+++ b/src/addressbook/e-book-backend-ews.c
@@ -1682,6 +1682,9 @@ ews_download_full_gal (EBookBackendEws *cbews,
 	gchar *full_url, *oab_url, *cache_file = NULL;
 	const gchar *cache_dir;
 	gchar *comp_cache_file = NULL, *uncompress_file = NULL;
+	CamelEwsSettings *settings;
+
+	settings = book_backend_ews_get_collection_settings (cbews);
 
 	/* oab url with oab.xml removed from the suffix */
 	oab_url = g_strndup (priv->oab_url, strlen (priv->oab_url) - 7);
@@ -1689,7 +1692,9 @@ ews_download_full_gal (EBookBackendEws *cbews,
 	cache_dir = e_book_backend_get_cache_dir (E_BOOK_BACKEND (cbews));
 	comp_cache_file = g_build_filename (cache_dir, full->filename, NULL);
 
-	oab_cnc = e_ews_connection_new (full_url, priv->username, priv->password, NULL, NULL, NULL);
+	oab_cnc = e_ews_connection_new (full_url, priv->username, priv->password,
+		camel_ews_settings_get_timeout (settings),
+		NULL, NULL, NULL);
 	if (!e_ews_connection_download_oal_file_sync (
 		oab_cnc, comp_cache_file, NULL, NULL, cancellable, error))
 		goto exit;
@@ -1837,11 +1842,15 @@ ebews_start_gal_sync (gpointer data)
 	GSList *full_l = NULL;
 	gboolean ret = TRUE;
 	gchar *uncompressed_filename = NULL;
+	CamelEwsSettings *settings;
 
 	cbews = (EBookBackendEws *) data;
+	settings = book_backend_ews_get_collection_settings (cbews);
 	priv = cbews->priv;
 
-	oab_cnc = e_ews_connection_new (priv->oab_url, priv->username, priv->password, NULL, NULL, NULL);
+	oab_cnc = e_ews_connection_new (priv->oab_url, priv->username, priv->password,
+		camel_ews_settings_get_timeout (settings),
+		NULL, NULL, NULL);
 
 	d(printf ("Ewsgal: Fetching oal full details file \n");)
 
@@ -2940,7 +2949,9 @@ book_backend_ews_try_password_sync (ESourceAuthenticator *authenticator,
 	user = camel_network_settings_dup_user (network_settings);
 
 	connection = e_ews_connection_new (
-		hosturl, user, password->str, NULL, NULL, error);
+		hosturl, user, password->str,
+		camel_ews_settings_get_timeout (ews_settings),
+		NULL, NULL, error);
 
 	if (connection == NULL) {
 		result = E_SOURCE_AUTHENTICATION_ERROR;
diff --git a/src/calendar/e-cal-backend-ews.c b/src/calendar/e-cal-backend-ews.c
index badf0e1..ffbcb53 100644
--- a/src/calendar/e-cal-backend-ews.c
+++ b/src/calendar/e-cal-backend-ews.c
@@ -4058,7 +4058,9 @@ cal_backend_ews_try_password_sync (ESourceAuthenticator *authenticator,
 	user = camel_network_settings_dup_user (network_settings);
 
 	connection = e_ews_connection_new (
-		hosturl, user, password->str, NULL, NULL, error);
+		hosturl, user, password->str,
+		camel_ews_settings_get_timeout (ews_settings),
+		NULL, NULL, error);
 
 	g_free (hosturl);
 	g_free (user);
diff --git a/src/camel/camel-ews-provider.c b/src/camel/camel-ews-provider.c
index 557b38b..32d843d 100644
--- a/src/camel/camel-ews-provider.c
+++ b/src/camel/camel-ews-provider.c
@@ -61,6 +61,12 @@ static CamelProviderConfEntry ews_conf_entries[] = {
 	  N_("Automatically synchroni_ze remote mail locally"), "0" },
 	{ CAMEL_PROVIDER_CONF_SECTION_END },
 
+	{ CAMEL_PROVIDER_CONF_SECTION_START, "connection", NULL, N_("Connection") },
+	{ CAMEL_PROVIDER_CONF_CHECKSPIN, "timeout", NULL,
+	  /* Translators: '%s' is preplaced with a widget, where user can select how long the timeout should be */
+	  N_("Connection _timeout (in seconds) %s"), "0:1:0:32768" },
+	{ CAMEL_PROVIDER_CONF_SECTION_END },
+
 	{ CAMEL_PROVIDER_CONF_END }
 };
 
diff --git a/src/camel/camel-ews-store.c b/src/camel/camel-ews-store.c
index 6d45483..f8b9772 100644
--- a/src/camel/camel-ews-store.c
+++ b/src/camel/camel-ews-store.c
@@ -215,6 +215,19 @@ ews_update_folder_hierarchy (CamelEwsStore *ews_store,
 }
 
 static void
+ews_store_update_cnc_timeout_cb (CamelEwsSettings *settings,
+				 GParamSpec *spec,
+				 CamelEwsStore *store)
+{
+	g_return_if_fail (CAMEL_IS_EWS_SETTINGS (settings));
+	g_return_if_fail (CAMEL_IS_EWS_STORE (store));
+
+	if (store->priv->cnc)
+		e_ews_connection_set_timeout (store->priv->cnc,
+			camel_ews_settings_get_timeout (settings));
+}
+
+static void
 ews_store_authenticate (EEwsConnection *cnc,
                         SoupMessage *msg,
                         SoupAuth *auth,
@@ -271,6 +284,7 @@ ews_connect_sync (CamelService *service,
 		return TRUE;
 
 	priv->cnc = e_ews_connection_new (hosturl, user, NULL,
+					  camel_ews_settings_get_timeout (ews_settings),
 					  G_CALLBACK (ews_store_authenticate), service,
 					  error);
 
@@ -289,6 +303,8 @@ ews_connect_sync (CamelService *service,
 		return FALSE;
 	}
 
+	g_signal_connect (ews_settings, "notify::timeout", G_CALLBACK (ews_store_update_cnc_timeout_cb), service);
+
 	camel_offline_store_set_online_sync (
 		CAMEL_OFFLINE_STORE (ews_store), TRUE, cancellable, NULL);
 
@@ -306,6 +322,7 @@ ews_disconnect_sync (CamelService *service,
 
 	/* TODO cancel all operations in the connection */
 	if (ews_store->priv->cnc) {
+		g_signal_handlers_disconnect_by_data (camel_service_get_settings (service), service);
 		e_ews_connection_forget_password (ews_store->priv->cnc);
 		g_object_unref (ews_store->priv->cnc);
 		ews_store->priv->cnc = NULL;
diff --git a/src/collection/e-ews-backend.c b/src/collection/e-ews-backend.c
index 61f7e4a..bc07b31 100644
--- a/src/collection/e-ews-backend.c
+++ b/src/collection/e-ews-backend.c
@@ -612,7 +612,9 @@ ews_backend_try_password_sync (ESourceAuthenticator *authenticator,
 	user = e_source_collection_dup_identity (collection_extension);
 
 	connection = e_ews_connection_new (
-		hosturl, user, password->str, NULL, NULL, error);
+		hosturl, user, password->str,
+		camel_ews_settings_get_timeout (settings),
+		NULL, NULL, error);
 
 	g_free (hosturl);
 	g_free (user);
diff --git a/src/configuration/e-mail-config-ews-oal-combo-box.c b/src/configuration/e-mail-config-ews-oal-combo-box.c
index 5aa08a5..6da8a4e 100644
--- a/src/configuration/e-mail-config-ews-oal-combo-box.c
+++ b/src/configuration/e-mail-config-ews-oal-combo-box.c
@@ -161,7 +161,9 @@ mail_config_ews_oal_combo_box_try_password_sync (ESourceAuthenticator *auth,
 
 	/* XXX This takes a GError but never fails, so skip it. */
 	cnc = e_ews_connection_new (
-		oab_url, user, password->str, NULL, NULL, NULL);
+		oab_url, user, password->str,
+		camel_ews_settings_get_timeout (ews_settings),
+		NULL, NULL, NULL);
 
 	e_ews_connection_get_oal_list_sync (
 		cnc, &oal_items, cancellable, &local_error);
diff --git a/src/server/camel-ews-settings.c b/src/server/camel-ews-settings.c
index bc0efaa..469cfef 100644
--- a/src/server/camel-ews-settings.c
+++ b/src/server/camel-ews-settings.c
@@ -35,6 +35,7 @@ struct _CamelEwsSettingsPrivate {
 	gchar *hosturl;
 	gchar *oaburl;
 	gchar *oal_selected;
+	guint timeout;
 };
 
 enum {
@@ -52,6 +53,7 @@ enum {
 	PROP_OAL_SELECTED,
 	PROP_PORT,
 	PROP_SECURITY_METHOD,
+	PROP_TIMEOUT,
 	PROP_USER
 };
 
@@ -147,6 +149,12 @@ ews_settings_set_property (GObject *object,
 				g_value_get_enum (value));
 			return;
 
+		case PROP_TIMEOUT:
+			camel_ews_settings_set_timeout (
+				CAMEL_EWS_SETTINGS (object),
+				g_value_get_uint (value));
+			return;
+
 		case PROP_USER:
 			camel_network_settings_set_user (
 				CAMEL_NETWORK_SETTINGS (object),
@@ -255,6 +263,13 @@ ews_settings_get_property (GObject *object,
 				CAMEL_NETWORK_SETTINGS (object)));
 			return;
 
+		case PROP_TIMEOUT:
+			g_value_set_uint (
+				value,
+				camel_ews_settings_get_timeout (
+				CAMEL_EWS_SETTINGS (object)));
+			return;
+
 		case PROP_USER:
 			g_value_take_string (
 				value,
@@ -423,6 +438,18 @@ camel_ews_settings_class_init (CamelEwsSettingsClass *class)
 			G_PARAM_CONSTRUCT |
 			G_PARAM_STATIC_STRINGS));
 
+	g_object_class_install_property (
+		object_class,
+		PROP_TIMEOUT,
+		g_param_spec_uint (
+			"timeout",
+			"timeout",
+			"Connection timeout in seconds",
+			0, G_MAXUINT, 120,
+			G_PARAM_READWRITE |
+			G_PARAM_CONSTRUCT |
+			G_PARAM_STATIC_STRINGS));
+
 	/* Inherited from CamelNetworkSettings. */
 	g_object_class_override_property (
 		object_class,
@@ -827,3 +854,24 @@ camel_ews_settings_set_oal_selected (CamelEwsSettings *settings,
 	g_object_notify (G_OBJECT (settings), "oal-selected");
 }
 
+guint
+camel_ews_settings_get_timeout (CamelEwsSettings *settings)
+{
+	g_return_val_if_fail (CAMEL_IS_EWS_SETTINGS (settings), 0);
+
+	return settings->priv->timeout;
+}
+
+void
+camel_ews_settings_set_timeout (CamelEwsSettings *settings,
+				guint timeout)
+{
+	g_return_if_fail (CAMEL_IS_EWS_SETTINGS (settings));
+
+	if (settings->priv->timeout == timeout)
+		return;
+
+	settings->priv->timeout = timeout;
+
+	g_object_notify (G_OBJECT (settings), "timeout");
+}
diff --git a/src/server/camel-ews-settings.h b/src/server/camel-ews-settings.h
index 55a5700..5fe4bbd 100644
--- a/src/server/camel-ews-settings.h
+++ b/src/server/camel-ews-settings.h
@@ -99,7 +99,9 @@ gchar *		camel_ews_settings_dup_oal_selected
 void		camel_ews_settings_set_oal_selected
 						(CamelEwsSettings *settings,
 						 const gchar *oal_selected);
-
+guint		camel_ews_settings_get_timeout	(CamelEwsSettings *settings);
+void		camel_ews_settings_set_timeout	(CamelEwsSettings *settings,
+						 guint timeout);
 G_END_DECLS
 
 #endif /* CAMEL_EWS_SETTINGS_H */
diff --git a/src/server/e-ews-connection.c b/src/server/e-ews-connection.c
index bc8630d..1fdf372 100644
--- a/src/server/e-ews-connection.c
+++ b/src/server/e-ews-connection.c
@@ -1084,9 +1084,10 @@ e_ews_connection_init (EEwsConnection *cnc)
 
 	/* create the SoupSession for this connection */
 	priv->soup_session = soup_session_async_new_with_options (SOUP_SESSION_USE_NTLM, TRUE,
-								  SOUP_SESSION_ASYNC_CONTEXT, priv->soup_context, NULL);
+								  SOUP_SESSION_ASYNC_CONTEXT, priv->soup_context,
+								  NULL);
 
-        if (getenv("EWS_DEBUG") && (atoi (g_getenv ("EWS_DEBUG")) >= 2)) {
+        if (g_getenv("EWS_DEBUG") && (atoi (g_getenv ("EWS_DEBUG")) >= 2)) {
 		SoupLogger *logger;
 		logger = soup_logger_new (SOUP_LOGGER_LOG_BODY, -1);
 		soup_session_add_feature (priv->soup_session, SOUP_SESSION_FEATURE (logger));
@@ -1227,6 +1228,7 @@ e_ews_connection_find (const gchar *uri,
  * @uri: Exchange server uri
  * @username:
  * @password:
+ * @timeout: connection timeout to use, in seconds
  * @error: Currently unused, but may require in future. Can take NULL value.
  *
  * This does not authenticate to the server. It merely stores the username and password.
@@ -1238,6 +1240,7 @@ EEwsConnection *
 e_ews_connection_new (const gchar *uri,
                       const gchar *username,
                       const gchar *password,
+		      guint timeout,
                       GCallback authenticate_cb,
                       gpointer authenticate_ctx,
                       GError **error)
@@ -1274,6 +1277,10 @@ e_ews_connection_new (const gchar *uri,
 	cnc->priv->password = g_strdup (password);
 	cnc->priv->uri = g_strdup (uri);
 
+	g_object_set (G_OBJECT (cnc->priv->soup_session),
+		SOUP_SESSION_TIMEOUT, timeout,
+		NULL);
+
 	/* register a handler to the authenticate signal */
 	if (authenticate_cb)
 		g_signal_connect (cnc, "authenticate",
@@ -1307,6 +1314,18 @@ e_ews_connection_forget_password (EEwsConnection *cnc)
 	cnc->priv->password = NULL;
 }
 
+void
+e_ews_connection_set_timeout (EEwsConnection *cnc,
+			      guint timeout)
+{
+	g_return_if_fail (cnc != NULL);
+
+	if (cnc->priv->soup_session)
+		g_object_set (G_OBJECT (cnc->priv->soup_session),
+			SOUP_SESSION_TIMEOUT, timeout,
+			NULL);
+}
+
 static xmlDoc *
 e_ews_autodiscover_ws_xml (const gchar *email_address)
 {
@@ -1678,7 +1697,8 @@ e_ews_autodiscover_ws_url (CamelEwsSettings *settings,
 	if (user == NULL || *user == '\0')
 		user = email_address;
 
-	cnc = e_ews_connection_new (url3, user, password, NULL, NULL, &error);
+	cnc = e_ews_connection_new (url3, user, password,
+		camel_ews_settings_get_timeout (settings), NULL, NULL, &error);
 	if (cnc == NULL) {
 		g_free (url1);
 		g_free (url2);
diff --git a/src/server/e-ews-connection.h b/src/server/e-ews-connection.h
index f51a74b..60ce0a3 100644
--- a/src/server/e-ews-connection.h
+++ b/src/server/e-ews-connection.h
@@ -187,12 +187,14 @@ GType		e_ews_connection_get_type	(void);
 EEwsConnection *e_ews_connection_new		(const gchar *uri,
 						 const gchar *username,
 						 const gchar *password,
+						 guint timeout,
 						 GCallback authenticate_cb,
 						 gpointer authenticate_ctx,
 						 GError **error);
 void		e_ews_connection_forget_password
 						(EEwsConnection *cnc);
-
+void		e_ews_connection_set_timeout	(EEwsConnection *cnc,
+						 guint timeout);
 EEwsConnection *e_ews_connection_find		(const gchar *uri,
 						 const gchar *username);
 void		e_ews_connection_authenticate	(EEwsConnection *cnc,
diff --git a/src/server/tests/test-autocompletion.c b/src/server/tests/test-autocompletion.c
index 82c90de..309dd0a 100644
--- a/src/server/tests/test-autocompletion.c
+++ b/src/server/tests/test-autocompletion.c
@@ -88,7 +88,7 @@ op_test_resolve_names ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 	e_ews_connection_resolve_names (
 		cnc, EWS_PRIORITY_MEDIUM, username,
diff --git a/src/server/tests/test-connection.c b/src/server/tests/test-connection.c
index b6c531d..bdc1d7a 100644
--- a/src/server/tests/test-connection.c
+++ b/src/server/tests/test-connection.c
@@ -54,7 +54,7 @@ con_test_create_new_connection ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	g_print ("\nSuccess : Created a new connection\n");
diff --git a/src/server/tests/test-createfolder.c b/src/server/tests/test-createfolder.c
index d32c220..db51822 100644
--- a/src/server/tests/test-createfolder.c
+++ b/src/server/tests/test-createfolder.c
@@ -85,7 +85,7 @@ op_test_create_folder ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 	e_ews_connection_create_folder (
 		cnc, EWS_PRIORITY_MEDIUM, "inbox",
diff --git a/src/server/tests/test-cuditem.c b/src/server/tests/test-cuditem.c
index 4f25064..fc02a60 100644
--- a/src/server/tests/test-cuditem.c
+++ b/src/server/tests/test-cuditem.c
@@ -108,7 +108,7 @@ op_test_create_item ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	//to check how to change to real data
diff --git a/src/server/tests/test-deletefolder.c b/src/server/tests/test-deletefolder.c
index 279372c..2ab1184 100644
--- a/src/server/tests/test-deletefolder.c
+++ b/src/server/tests/test-deletefolder.c
@@ -76,7 +76,7 @@ op_test_delete_folder (gpointer data)
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 	e_ews_connection_delete_folder (
 		cnc, EWS_PRIORITY_MEDIUM, (*fid)->id,
diff --git a/src/server/tests/test-get-oof-settings.c b/src/server/tests/test-get-oof-settings.c
index 2476626..e62ba48 100644
--- a/src/server/tests/test-get-oof-settings.c
+++ b/src/server/tests/test-get-oof-settings.c
@@ -77,7 +77,7 @@ op_test_get_oof_settings ()
 	g_assert_cmpstr (uri, !=, NULL);
 	g_assert_cmpstr (email, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	e_ews_connection_set_mailbox (cnc, email);
diff --git a/src/server/tests/test-getattachment.c b/src/server/tests/test-getattachment.c
index bf25465..d8408fa 100644
--- a/src/server/tests/test-getattachment.c
+++ b/src/server/tests/test-getattachment.c
@@ -81,7 +81,7 @@ op_test_get_attachments ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	attachmentid = "AAASAG1hbmR5Lnd1QGludGVsLmNvbQBGAAAAAACdSXexmsgJTpd3WpdX6ulXBwAm9E+BClHfQqEnvCoGvhheAAAAjpb6AACIeDU1D80fTrC3245yXdhOADUAPRB8AAABEgAQAIlh9YZzdzdMtvWW9ZI7+vM=";
diff --git a/src/server/tests/test-getdelegate.c b/src/server/tests/test-getdelegate.c
index 2223b47..88ce0b7 100644
--- a/src/server/tests/test-getdelegate.c
+++ b/src/server/tests/test-getdelegate.c
@@ -84,7 +84,7 @@ op_test_get_delegate ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 	e_ews_connection_get_delegate (
 		cnc, EWS_PRIORITY_MEDIUM, "abc xyz com",
diff --git a/src/server/tests/test-set-oof-settings.c b/src/server/tests/test-set-oof-settings.c
index 3f0b503..4acdec9 100644
--- a/src/server/tests/test-set-oof-settings.c
+++ b/src/server/tests/test-set-oof-settings.c
@@ -92,7 +92,7 @@ op_test_set_oof_settings ()
 	g_assert_cmpstr (uri, !=, NULL);
 	g_assert_cmpstr (email, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	e_ews_connection_set_mailbox (cnc, email);
diff --git a/src/server/tests/test-syncfolder.c b/src/server/tests/test-syncfolder.c
index 22982cb..9078329 100644
--- a/src/server/tests/test-syncfolder.c
+++ b/src/server/tests/test-syncfolder.c
@@ -100,7 +100,7 @@ op_test_sync_folder_items ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	e_ews_connection_sync_folder_items (
@@ -173,7 +173,7 @@ op_test_sync_folder_hierarchy ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	e_ews_connection_sync_folder_hierarchy (
@@ -234,7 +234,7 @@ op_test_get_item ()
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	ids = g_slist_reverse (ids);
diff --git a/src/utils/ews-test-finditem-query.c b/src/utils/ews-test-finditem-query.c
index 6e38556..3af2e83 100644
--- a/src/utils/ews-test-finditem-query.c
+++ b/src/utils/ews-test-finditem-query.c
@@ -112,7 +112,7 @@ op_test_finditem_run (void)
 	g_assert_cmpstr (password, !=, NULL);
 	g_assert_cmpstr (uri, !=, NULL);
 
-	cnc = e_ews_connection_new (uri, username, password, NULL, NULL, NULL);
+	cnc = e_ews_connection_new (uri, username, password, 0, NULL, NULL, NULL);
 	g_assert (cnc != NULL);
 
 	/*Along with finditem api we check query conversion too*/
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]