[tracker/miner-fs-no-infinite-loops: 2/7] libtracker-miner: Remove unneeded call to item_queue_handlers_set_up()



commit 722312a3c21c51a0cc3dfd4b7b417b73c45ea6fa
Author: Sam Thursfield <sam thursfield codethink co uk>
Date:   Thu Jun 14 17:52:15 2012 +0100

    libtracker-miner: Remove unneeded call to item_queue_handlers_set_up()
    
    item_add_or_update_cb() does not usually need to call this function as
    the item queue is not stopped while waiting for extraction tasks. We
    do need to call it if the queues are empty to ensure a QUEUE_NONE
    event is processed.

 src/libtracker-miner/tracker-miner-fs.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/libtracker-miner/tracker-miner-fs.c b/src/libtracker-miner/tracker-miner-fs.c
index fb44d5c..eaa4e73 100644
--- a/src/libtracker-miner/tracker-miner-fs.c
+++ b/src/libtracker-miner/tracker-miner-fs.c
@@ -1242,7 +1242,9 @@ item_add_or_update_cb (TrackerMinerFS *fs,
 		}
 	}
 
-	if (!tracker_task_pool_limit_reached (TRACKER_TASK_POOL (fs->priv->sparql_buffer))) {
+	if (tracker_miner_fs_has_items_to_process (fs) == FALSE &&
+	    tracker_task_pool_get_size (TRACKER_TASK_POOL (fs->priv->task_pool)) == 0) {
+		/* We need to run this one more time to trigger process_stop() */
 		item_queue_handlers_set_up (fs);
 	}
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]