[gimp] Bug 664885 - Open 'Document History' --> always a additional history tab appears
- From: Michael Natterer <mitch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] Bug 664885 - Open 'Document History' --> always a additional history tab appears
- Date: Tue, 31 Jan 2012 21:01:57 +0000 (UTC)
commit d11f9d7dbfa00ca3ef150fe54666d7a4717115b2
Author: Michael Natterer <mitch gimp org>
Date: Tue Jan 31 22:00:17 2012 +0100
Bug 664885 - Open 'Document History' --> always a additional history tab appears
Really find a *widget* in gimp_dialog_factory_find_widget(), don't
just return the first found session info's widget. It's perfectly fine
for a session info to have a NULL widget, if that dialog is not
currently open.
app/widgets/gimpdialogfactory.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
---
diff --git a/app/widgets/gimpdialogfactory.c b/app/widgets/gimpdialogfactory.c
index 000cdf7..ce057c2 100644
--- a/app/widgets/gimpdialogfactory.c
+++ b/app/widgets/gimpdialogfactory.c
@@ -352,8 +352,9 @@ GtkWidget *
gimp_dialog_factory_find_widget (GimpDialogFactory *factory,
const gchar *identifiers)
{
- gchar **ids;
- gint i;
+ GtkWidget *widget = NULL;
+ gchar **ids;
+ gint i;
g_return_val_if_fail (GIMP_IS_DIALOG_FACTORY (factory), NULL);
g_return_val_if_fail (identifiers != NULL, NULL);
@@ -368,15 +369,16 @@ gimp_dialog_factory_find_widget (GimpDialogFactory *factory,
if (info)
{
- g_strfreev (ids);
+ widget = gimp_session_info_get_widget (info);
- return gimp_session_info_get_widget (info);
+ if (widget)
+ break;
}
}
g_strfreev (ids);
- return NULL;
+ return widget;
}
/**
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]