[cogl/fosdem-2012] kms: gracefully handle NULL save_state at cleanup
- From: Robert Bragg <rbragg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [cogl/fosdem-2012] kms: gracefully handle NULL save_state at cleanup
- Date: Mon, 23 Jan 2012 15:41:09 +0000 (UTC)
commit b28c29b8b78843e4847fcf5c16be97a5d6172bfa
Author: Robert Bragg <robert linux intel com>
Date: Mon Jan 23 15:39:10 2012 +0000
kms: gracefully handle NULL save_state at cleanup
If we failed to save any crtc state then we skip trying to restore the
old state at cleanup.
cogl/winsys/cogl-winsys-egl-kms.c | 25 ++++++++++++++-----------
1 files changed, 14 insertions(+), 11 deletions(-)
---
diff --git a/cogl/winsys/cogl-winsys-egl-kms.c b/cogl/winsys/cogl-winsys-egl-kms.c
index 58de181..a46104d 100644
--- a/cogl/winsys/cogl-winsys-egl-kms.c
+++ b/cogl/winsys/cogl-winsys-egl-kms.c
@@ -293,19 +293,22 @@ _cogl_winsys_egl_cleanup_context (CoglDisplay *display)
CoglRenderer *renderer = display->renderer;
CoglRendererEGL *egl_renderer = renderer->winsys;
CoglRendererKMS *kms_renderer = egl_renderer->platform;
- int ret;
/* Restore the saved CRTC - this failing should not propagate an error */
- ret = drmModeSetCrtc (kms_renderer->fd,
- kms_display->saved_crtc->crtc_id,
- kms_display->saved_crtc->buffer_id,
- kms_display->saved_crtc->x, kms_display->saved_crtc->y,
- &kms_display->connector->connector_id, 1,
- &kms_display->saved_crtc->mode);
- if (ret)
- g_critical (G_STRLOC ": Error restoring saved CRTC");
-
- drmModeFreeCrtc (kms_display->saved_crtc);
+ if (kms_display->saved_crtc)
+ {
+ int ret = drmModeSetCrtc (kms_renderer->fd,
+ kms_display->saved_crtc->crtc_id,
+ kms_display->saved_crtc->buffer_id,
+ kms_display->saved_crtc->x,
+ kms_display->saved_crtc->y,
+ &kms_display->connector->connector_id, 1,
+ &kms_display->saved_crtc->mode);
+ if (ret)
+ g_critical (G_STRLOC ": Error restoring saved CRTC");
+
+ drmModeFreeCrtc (kms_display->saved_crtc);
+ }
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]