[gvfs/wip/udisks2] Expand TODO item pontificating whether a GDrive should be added or not
- From: David Zeuthen <davidz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gvfs/wip/udisks2] Expand TODO item pontificating whether a GDrive should be added or not
- Date: Fri, 20 Jan 2012 18:13:04 +0000 (UTC)
commit 8310b421d7e61f0ee14f7766ff5aac3813f37731
Author: David Zeuthen <davidz redhat com>
Date: Fri Jan 20 13:12:36 2012 -0500
Expand TODO item pontificating whether a GDrive should be added or not
Signed-off-by: David Zeuthen <davidz redhat com>
monitor/udisks2/gvfsudisks2volumemonitor.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
---
diff --git a/monitor/udisks2/gvfsudisks2volumemonitor.c b/monitor/udisks2/gvfsudisks2volumemonitor.c
index 09c8aaa..de9edc2 100644
--- a/monitor/udisks2/gvfsudisks2volumemonitor.c
+++ b/monitor/udisks2/gvfsudisks2volumemonitor.c
@@ -870,9 +870,17 @@ static gboolean
should_include_drive (GVfsUDisks2VolumeMonitor *monitor,
UDisksDrive *drive)
{
- gboolean ret = TRUE;
- /* TODO */
- return ret;
+ /* For now, we just include all detected drives. This is probably
+ * wrong - non-removable drives without anything visible (such
+ * RAID components) should probably not be shown.
+ *
+ * Then again, the GNOME 3 user interface doesn't really show GDrive
+ * instances except for in the computer:/// location in Nautilus.
+ *
+ * TODO: if device is non-removable, maybe only show it, if it has
+ * more visible devices
+ */
+ return TRUE;
}
/* ---------------------------------------------------------------------------------------------------- */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]