[gnome-disk-utility/udisks2-port] Add reference to bug 657194 in places where we hard-code text colors
- From: David Zeuthen <davidz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-disk-utility/udisks2-port] Add reference to bug 657194 in places where we hard-code text colors
- Date: Thu, 12 Jan 2012 17:49:34 +0000 (UTC)
commit 4abb68cc4124e0498bc9c81e1a1fa1490eabe60b
Author: David Zeuthen <davidz redhat com>
Date: Thu Jan 12 12:48:54 2012 -0500
Add reference to bug 657194 in places where we hard-code text colors
Bug 657194: https://bugzilla.gnome.org/show_bug.cgi?id=657194
Signed-off-by: David Zeuthen <davidz redhat com>
src/palimpsest/gduatasmartdialog.c | 15 +++++++++++++++
src/palimpsest/gdudevicetreemodel.c | 18 ++++++++++++++++++
2 files changed, 33 insertions(+), 0 deletions(-)
---
diff --git a/src/palimpsest/gduatasmartdialog.c b/src/palimpsest/gduatasmartdialog.c
index 915b697..a51c68f 100644
--- a/src/palimpsest/gduatasmartdialog.c
+++ b/src/palimpsest/gduatasmartdialog.c
@@ -672,12 +672,18 @@ attr_format_assessment (gint current,
if (failed)
{
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
ret = g_strdup_printf ("<span foreground=\"#ff0000\"><b>%s</b></span>",
/* Translators: Shown in the treeview for a failing attribute */
_("FAILING"));
}
else if (failed_in_the_past)
{
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
ret = g_strdup_printf ("<span foreground=\"#ff0000\">%s</span>",
/* Translators: Shown in the treeview for an attribute that failed in the past */
_("Failed in the past"));
@@ -1076,12 +1082,18 @@ gdu_ata_smart_get_overall_assessment (UDisksDriveAta *ata,
/* if doing a one-liner also include if a self-test is running */
if (one_liner && selftest != NULL)
{
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
ret = g_strdup_printf ("<span foreground=\"#ff0000\"><b>%s</b></span> â %s",
_("DISK IS LIKELY TO FAIL SOON"),
selftest);
}
else
{
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
ret = g_strdup_printf ("<span foreground=\"#ff0000\"><b>%s</b></span>",
_("DISK IS LIKELY TO FAIL SOON"));
}
@@ -1102,6 +1114,9 @@ gdu_ata_smart_get_overall_assessment (UDisksDriveAta *ata,
/* Otherwise, if last self-test failed, return that for the one-liner */
if (g_str_has_prefix (udisks_drive_ata_get_smart_selftest_status (ata), "error"))
{
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
ret = g_strdup_printf ("<span foreground=\"#ff0000\"><b>%s</b></span>",
_("SELF-TEST FAILED"));
warn = TRUE;
diff --git a/src/palimpsest/gdudevicetreemodel.c b/src/palimpsest/gdudevicetreemodel.c
index 2f8431c..f84f26b 100644
--- a/src/palimpsest/gdudevicetreemodel.c
+++ b/src/palimpsest/gdudevicetreemodel.c
@@ -403,6 +403,9 @@ get_drive_header_iter (GduDeviceTreeModel *model)
if (model->drive_iter_valid)
goto out;
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
s = g_strdup_printf ("<small><span foreground=\"#555555\">%s</span></small>",
_("Disk Drives"));
gtk_tree_store_insert_with_values (GTK_TREE_STORE (model),
@@ -673,6 +676,9 @@ update_drive (GduDeviceTreeModel *model,
&media_icon);
if (warning)
{
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
s = g_strdup_printf ("<span foreground=\"#ff0000\">%s</span>\n"
"<small><span foreground=\"#ff0000\">%s</span></small>",
description,
@@ -680,6 +686,9 @@ update_drive (GduDeviceTreeModel *model,
}
else
{
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
s = g_strdup_printf ("%s\n"
"<small><span foreground=\"#555555\">%s</span></small>",
description,
@@ -804,6 +813,9 @@ get_block_header_iter (GduDeviceTreeModel *model)
if (model->block_iter_valid)
goto out;
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
s = g_strdup_printf ("<small><span foreground=\"#555555\">%s</span></small>",
_("Other Devices"));
gtk_tree_store_insert_with_values (GTK_TREE_STORE (model),
@@ -914,6 +926,9 @@ update_block (GduDeviceTreeModel *model,
/* loop devices */
icon = g_themed_icon_new ("drive-removable-media"); /* for now */
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
s = g_strdup_printf ("%s\n"
"<small><span foreground=\"#555555\">%s</span></small>",
loop_name,
@@ -934,6 +949,9 @@ update_block (GduDeviceTreeModel *model,
/* fallback: preferred device and drive-harddisk icon */
icon = g_themed_icon_new ("drive-removable-media"); /* for now */
+ /* TODO: once https://bugzilla.gnome.org/show_bug.cgi?id=657194 is resolved, use that instead
+ * of hard-coding the color
+ */
s = g_strdup_printf ("%s\n"
"<small><span foreground=\"#555555\">%s</span></small>",
block_name,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]