[gtk+] GtkButton: don't do string compare on property set
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] GtkButton: don't do string compare on property set
- Date: Wed, 11 Jan 2012 05:31:43 +0000 (UTC)
commit b7a28de755cdb226059012de550d5b13dc904770
Author: Ryan Lortie <desrt desrt ca>
Date: Mon Jan 9 15:21:18 2012 +0100
GtkButton: don't do string compare on property set
Just set the property unconditionally.
https://bugzilla.gnome.org/show_bug.cgi?id=667394
gtk/gtkbutton.c | 11 ++++-------
1 files changed, 4 insertions(+), 7 deletions(-)
---
diff --git a/gtk/gtkbutton.c b/gtk/gtkbutton.c
index cc159c4..564483b 100644
--- a/gtk/gtkbutton.c
+++ b/gtk/gtkbutton.c
@@ -734,15 +734,12 @@ gtk_button_set_action_name (GtkActionable *actionable,
g_return_if_fail (GTK_IS_BUTTON (button));
g_return_if_fail (button->priv->action == NULL);
- if (g_strcmp0 (action_name, button->priv->action_name) != 0)
- {
- g_free (button->priv->action_name);
- button->priv->action_name = g_strdup (action_name);
+ g_free (button->priv->action_name);
+ button->priv->action_name = g_strdup (action_name);
- gtk_button_update_action_observer (button);
+ gtk_button_update_action_observer (button);
- g_object_notify (G_OBJECT (button), "action-name");
- }
+ g_object_notify (G_OBJECT (button), "action-name");
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]